Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spaces flaky test #118309

Merged
merged 3 commits into from
Nov 24, 2021
Merged

Fix spaces flaky test #118309

merged 3 commits into from
Nov 24, 2021

Conversation

thomheymann
Copy link
Contributor

@thomheymann thomheymann commented Nov 11, 2021 •
edited
Loading

Only Firefox fails very intermittently.

It's better to have these functional tests in place without Firefox than none at all.

Skip Firefox until root cause for intermittent test failures understood.

Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/229 ✅

@thomheymann thomheymann added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed buildkite-ci v8.1.0 v7.16.1 labels Nov 11, 2021
@thomheymann thomheymann requested a review from a team November 11, 2021 10:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@thomheymann
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@thomheymann
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Nov 23, 2021
jportner
jportner approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we should merge these changes, but I don't agree with

Resolves #100570

That issue should stay open until we figure out the root cause and re-enable these tests in Firefox.

Other than that, LGTM

@thomheymann thomheymann merged commit c6f491c into elastic:main Nov 24, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 24, 2021
@thomheymann @kibanamachine
Skip firefox until resolved (elastic#118309)
266f3d1 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Nov 24, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 24, 2021
@thomheymann @kibanamachine
Skip firefox until resolved (elastic#118309)
b40baec 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Nov 24, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0
✅ 7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 24, 2021
@kibanamachine @thomheymann
Skip firefox until resolved (#118309) (#119587)
bbb4285 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Thom Heymann <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 24, 2021
@kibanamachine @thomheymann
Skip firefox until resolved (#118309) (#119588)
402aaba 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Thom Heymann <[email protected]>
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
@thomheymann @kibanamachine @dmlemeshko
Skip firefox until resolved (#118309)
d00a938 
Co-authored-by: Kibana Machine <[email protected]>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@thomheymann @kibanamachine @TinLe
Skip firefox until resolved (elastic#118309)
97f0199 
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jportner jportner jportner approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed buildkite-ci release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.16.1 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thomheymann @elasticmachine @kibanamachine @kibana-ci @jportner