[ML] Model management fixes and usability enhancements #118240

darnautov · 2021-11-10T20:35:57Z

Summary

Follow-up fix for the ES API endpoints update that removes deployment stats endpoint and append this info to the trained model stats endpoint.

Pipelines overview

Improves readability for the ingest stats and combines them with pipelines definitions.

Deployment stats

Improves readability of the deployment stats
Adds recently introduced properties start_time and number_of_pending_requests

Nodes overview

Adds missing formatting for nodes attributes
Removes redundant fields from the node details

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

elasticmachine · 2021-11-11T16:53:38Z

Pinging @elastic/ml-ui (:ml)

pheyos · 2021-11-15T07:10:53Z

@darnautov this PR should fix the tests that have been skipped in #118251, could you please re-enable them as part of this PR?

darnautov · 2021-11-15T10:04:50Z

@darnautov this PR should fix the tests that have been skipped in #118251, could you please re-enable them as part of this PR?

@pheyos done in b8c14ef

peteharverson · 2021-11-16T10:20:39Z

...ck/plugins/ml/public/application/trained_models/models_management/pipelines/expended_row.tsx

+      },
+      'data-test-subj': 'mlProcessorStatsType',
+    },
+    {


Can info icons be added with help popovers for the Count, Time per doc, Current and Failed columns, using the text suggested in the feedback doc?

Added in 4a5e4bd

x-pack/plugins/ml/public/application/trained_models/models_management/expanded_row.tsx

qn895 · 2021-11-16T15:15:39Z

Code LGTM 🎉

jgowdyelastic

Changes to the capabilities LGTM

...ck/plugins/ml/public/application/trained_models/models_management/pipelines/expended_row.tsx

peteharverson

Latest edits LGTM

darnautov · 2021-11-22T08:43:36Z

@elasticmachine merge upstream

kibana-ci · 2021-11-22T10:18:51Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`ml`	1573	1578	+5

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`ml`	278	279	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`ml`	3.5MB	3.5MB	-2.2KB
`securitySolution`	4.5MB	4.5MB	-577.0B
total			-2.7KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`ml`	33	34	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`ml`	33.8KB	37.7KB	+3.9KB
`securitySolution`	249.5KB	249.7KB	+132.0B
total			+4.0KB

Unknown metric groups

API count

id	before	after	diff
`ml`	282	283	+1

References to deprecated APIs

id	before	after	diff
`ml`	79	77	-2

History

💛 Build #7105 was flaky 6440a41
💔 Build #7044 failed c3ed3e4
💔 Build #7005 failed 4a5e4bd
💔 Build #6941 failed bf328c8
💔 Build #6724 failed 76caf13
💔 Build #6667 failed 526ffe7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

* [ML] update expanded rows on refresh * [ML] truncateText for start and state columns * remove deployment stats endpoints, replace with the trained models stats * update layout for pipelines * add edit icon * rename deployment actions * add panels for pipelines tab * change deployment stats layout * remove redundant fields from node details * render roles with badges * format nodes attrs * hide empty stats tab * enable trained models tests * add canViewMlNodes capability, hide Nodes tab for the viewer * remove unused translation * support force stop * import default ml capabilities in the security_solutions plugin * update translation string id * Revert "support force stop" This reverts commit 1b1a3b2 * fix translation string ids * remove mock id * rename test subject * remove getTrainedModelDeploymentStats leftovers * update tags for nodes_overview endpoint * update api integration tests * fix paddings * add info icons for ingest stats * update api integration tests for capabilities with spaces * expand first 3 pipelines by default * fix typo in the filename * add help_icon component * fix test assertion

kibanamachine · 2021-11-22T10:22:43Z

💚 Backport successful

Status	Branch	Result
✅	8.0

This backport PR will be merged automatically after passing CI.

…9293) * [ML] update expanded rows on refresh * [ML] truncateText for start and state columns * remove deployment stats endpoints, replace with the trained models stats * update layout for pipelines * add edit icon * rename deployment actions * add panels for pipelines tab * change deployment stats layout * remove redundant fields from node details * render roles with badges * format nodes attrs * hide empty stats tab * enable trained models tests * add canViewMlNodes capability, hide Nodes tab for the viewer * remove unused translation * support force stop * import default ml capabilities in the security_solutions plugin * update translation string id * Revert "support force stop" This reverts commit 1b1a3b2 * fix translation string ids * remove mock id * rename test subject * remove getTrainedModelDeploymentStats leftovers * update tags for nodes_overview endpoint * update api integration tests * fix paddings * add info icons for ingest stats * update api integration tests for capabilities with spaces * expand first 3 pipelines by default * fix typo in the filename * add help_icon component * fix test assertion Co-authored-by: Dima Arnautov <[email protected]>

* [ML] update expanded rows on refresh * [ML] truncateText for start and state columns * remove deployment stats endpoints, replace with the trained models stats * update layout for pipelines * add edit icon * rename deployment actions * add panels for pipelines tab * change deployment stats layout * remove redundant fields from node details * render roles with badges * format nodes attrs * hide empty stats tab * enable trained models tests * add canViewMlNodes capability, hide Nodes tab for the viewer * remove unused translation * support force stop * import default ml capabilities in the security_solutions plugin * update translation string id * Revert "support force stop" This reverts commit 1b1a3b2 * fix translation string ids * remove mock id * rename test subject * remove getTrainedModelDeploymentStats leftovers * update tags for nodes_overview endpoint * update api integration tests * fix paddings * add info icons for ingest stats * update api integration tests for capabilities with spaces * expand first 3 pipelines by default * fix typo in the filename * add help_icon component * fix test assertion

darnautov added 3 commits November 10, 2021 16:20

[ML] update expanded rows on refresh

c65b6f1

[ML] truncateText for start and state columns

4e1382d

remove deployment stats endpoints, replace with the trained models stats

c8ae87f

darnautov self-assigned this Nov 10, 2021

darnautov added 9 commits November 11, 2021 14:08

update layout for pipelines

6cb7e95

add edit icon

9af72f0

rename deployment actions

fd8377d

add panels for pipelines tab

e349da7

change deployment stats layout

7e46343

remove redundant fields from node details

dd37992

render roles with badges

3e56b06

format nodes attrs

e8b2199

hide empty stats tab

df2578e

darnautov requested review from peteharverson and qn895 November 11, 2021 16:45

darnautov added :ml Feature:3rd Party Models ML 3rd party models release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) v8.0.0 v8.1.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Nov 11, 2021

darnautov marked this pull request as ready for review November 11, 2021 16:53

darnautov requested a review from a team as a code owner November 11, 2021 16:53

darnautov added 2 commits November 15, 2021 10:27

Merge remote-tracking branch 'upstream/main' into ml-mm-usability

a220682

enable trained models tests

b8c14ef

peteharverson reviewed Nov 16, 2021

View reviewed changes

x-pack/plugins/ml/public/application/trained_models/models_management/expanded_row.tsx Show resolved Hide resolved

darnautov added 5 commits November 16, 2021 13:21

update api integration tests

a4c68d9

fix paddings

2b35886

add info icons for ingest stats

4a5e4bd

update api integration tests for capabilities with spaces

a4ab250

expand first 3 pipelines by default

c3ed3e4

darnautov requested a review from peteharverson November 16, 2021 15:06

qn895 approved these changes Nov 16, 2021

View reviewed changes

jgowdyelastic approved these changes Nov 16, 2021

View reviewed changes

peteharverson reviewed Nov 16, 2021

View reviewed changes

...ck/plugins/ml/public/application/trained_models/models_management/pipelines/expended_row.tsx Outdated Show resolved Hide resolved

...ck/plugins/ml/public/application/trained_models/models_management/pipelines/expended_row.tsx Outdated Show resolved Hide resolved

darnautov added 3 commits November 16, 2021 17:47

fix typo in the filename

d54dc9d

add help_icon component

b6c3447

fix test assertion

6440a41

peteharverson approved these changes Nov 16, 2021

View reviewed changes

darnautov enabled auto-merge (squash) November 16, 2021 18:14

Merge branch 'main' into ml-mm-usability

08aaf05

darnautov disabled auto-merge November 22, 2021 10:19

darnautov merged commit 17fcc35 into elastic:main Nov 22, 2021

darnautov deleted the ml-mm-usability branch November 22, 2021 10:19

kibanamachine mentioned this pull request Nov 22, 2021

[8.0] [ML] Model management fixes and usability enhancements (#118240) #119293

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Model management fixes and usability enhancements #118240

[ML] Model management fixes and usability enhancements #118240

darnautov commented Nov 10, 2021 •

edited

Loading

elasticmachine commented Nov 11, 2021

pheyos commented Nov 15, 2021

darnautov commented Nov 15, 2021

peteharverson Nov 16, 2021

darnautov Nov 16, 2021

qn895 commented Nov 16, 2021

jgowdyelastic left a comment

peteharverson left a comment

darnautov commented Nov 22, 2021

kibana-ci commented Nov 22, 2021

API count

References to deprecated APIs

kibanamachine commented Nov 22, 2021

[ML] Model management fixes and usability enhancements #118240

[ML] Model management fixes and usability enhancements #118240

Conversation

darnautov commented Nov 10, 2021 • edited Loading

Summary

Pipelines overview

Deployment stats

Nodes overview

Checklist

elasticmachine commented Nov 11, 2021

pheyos commented Nov 15, 2021

darnautov commented Nov 15, 2021

peteharverson Nov 16, 2021

Choose a reason for hiding this comment

darnautov Nov 16, 2021

Choose a reason for hiding this comment

qn895 commented Nov 16, 2021

jgowdyelastic left a comment

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

darnautov commented Nov 22, 2021

kibana-ci commented Nov 22, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

References to deprecated APIs

History

kibanamachine commented Nov 22, 2021

💚 Backport successful

darnautov commented Nov 10, 2021 •

edited

Loading