[Exploratory View] Make series editor header sticky #118223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awahab07
changed the title
awahab07
added
bug
|
Pinging @elastic/uptime (Team:uptime) |
awahab07
changed the title
awahab07
changed the title
awahab07
added
release_note:skip
|
Should wait for #118238 and accommodate the changes. |
awahab07
force-pushed
the
117131-Exploratory-View-Apply-Changes-Hides
branch
from
ae8c9f9 to
c30e6e5
Compare
|
Reset button removed in #118095. Updated screenshots:
|
shahzad31
reviewed
Nov 11, 2021
There was a problem hiding this comment.
Stickiness looks good, i noticed that when user starts scroling it moves slighltly before it get's stickked, i think there is some extra padding on top of row, which we should remove, i think this view is already constrained, we can either remove the padding or decrease it.
|
Good point @shahzad31. We can remove the top padding, and have the EuiResizableButton on top make for the top padding. The header in this case would have an imbalanced top and bottom paddings, but wouldn't look imbalanced due to the resize button above. |
awahab07
force-pushed
the
117131-Exploratory-View-Apply-Changes-Hides
branch
from
c30e6e5 to
860217f
Compare
awahab07
force-pushed
the
117131-Exploratory-View-Apply-Changes-Hides
branch
from
860217f to
5cc3d1a
Compare
|
Incorporating #118223 (review) and merging with #117067. Updated video and screenshots: 118223.Section.sticky.header.mov
|
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
awahab07
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 17, 2021
* Make exploratory view series editor section header sticky when scrolled so that Apply Changes button is always in view. (elastic#118223) (elastic#117131)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 17, 2021
* Make exploratory view series editor section header sticky when scrolled so that Apply Changes button is always in view. (elastic#118223) (elastic#117131)
kibanamachine
added a commit
that referenced
this pull request
Nov 17, 2021
* Make exploratory view series editor section header sticky when scrolled so that Apply Changes button is always in view. (#118223) (#117131) Co-authored-by: Abdul Wahab Zahid <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 17, 2021
* Make exploratory view series editor section header sticky when scrolled so that Apply Changes button is always in view. (#118223) (#117131) Co-authored-by: Abdul Wahab Zahid <[email protected]>
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Nov 20, 2021
* Make exploratory view series editor section header sticky when scrolled so that Apply Changes button is always in view. (elastic#118223) (elastic#117131)
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117131
Summary
Make the header actions header on series editor on Exploratory View sticky, because the Apply Changes button scrolls off the container.
Before
https://user-images.githubusercontent.com/2748376/141177629-c859f669-04e6-45f9-b41d-2ccbb295ddf0.mp4
After
https://user-images.githubusercontent.com/2748376/141177679-1c9315f9-06c4-40de-876a-87691836add9.mp4
Screenshots
Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker listFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately