-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Surface deprecation logs from CI #117937
Surface deprecation logs from CI #117937
Conversation
56c8cac
to
ffac9e2
Compare
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
Pinging @elastic/kibana-core (Team:Core) |
@@ -308,7 +336,9 @@ export function createTestEsCluster< | |||
* in this list. | |||
*/ | |||
getHostUrls(): string[] { | |||
return this.ports.map((p) => format({ ...esTestConfig.getUrlParts(), port: p })); | |||
return this.ports.map((p) => | |||
format({ ...esTestConfig.getUrlParts(ssl), port: p, protocol: ssl ? 'https' : 'http' }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elastic/kibana-operations I have to override protocol here because TEST_ES_URL doesn't have the correct protocol. So although this works it feels a bit hacky.
@elasticmachine merge upstream |
99280e3
to
7f6bc05
Compare
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Summary
Experiment to see how many tests create deprecation logs. Not intended to be merged as is.
How to use this:
@elasticmachine merge upstream
to merge in the latest 7.16 changes and kick off a buildCurrent deprecation logs 1 Dec
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers