[Fleet] Fixing unnecessary network requests on showing Fleet Server on prem instructions #117647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaElastic
added
v8.0.0
release_note:skip
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
kpollich
requested changes
Nov 5, 2021
...eet/sections/agents/agent_requirements_page/components/fleet_server_on_prem_instructions.tsx
Outdated
Show resolved
Hide resolved
nchaulet
approved these changes
Nov 5, 2021
|
@kpollich are you okay with latest changes? I can't merge until it shows as change requested |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 8, 2021
…n prem instructions (elastic#117647) * removed fn dependency * fixing useDefaultOutput * fixed tslint
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 8, 2021
…n prem instructions (elastic#117647) * removed fn dependency * fixing useDefaultOutput * fixed tslint
kibanamachine
added a commit
that referenced
this pull request
Nov 8, 2021
…n prem instructions (#117647) (#117867) * removed fn dependency * fixing useDefaultOutput * fixed tslint Co-authored-by: Julia Bardi <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 8, 2021
…n prem instructions (#117647) (#117866) * removed fn dependency * fixing useDefaultOutput * fixed tslint Co-authored-by: Julia Bardi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug I observed in v7.16, v8.0
When opening Fleet UI for the first time, there are continuous
/settingsand/outputsnetwork calls being made (~3k/min).By digging in the code, it seems related to
useEffecthavingrefreshfunction as dependency.https://github.com/elastic/kibana/blob/main/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_requirements_page/components/fleet_server_on_prem_instructions.tsx#L281
https://github.com/elastic/kibana/blob/main/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_requirements_page/components/fleet_server_on_prem_instructions.tsx#L701
By removing this dependency, the extra network requests no longer happen, only when the
Fleet settingsmodal is toggled as expected.This feature was initially implemented here: #103550