[heatmap] Fix x time scale with calendar intervals #117619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
force-pushed
the
2021_11_03-fix_heatmap
branch
from
3ead173 to
12cf9ff
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
markov00
added
auto-backport
|
Pinging @elastic/datavis (Feature:ElasticCharts) |
dej611
approved these changes
Nov 9, 2021
darnautov
approved these changes
Nov 9, 2021
💔 Backport failed
To backport manually run: |
markov00
added a commit
to markov00/kibana
that referenced
this pull request
Nov 9, 2021
The commit fixes the Lens heatmap time axis when used with calendars time intervals in date_histogram aggs # Conflicts: # package.json # yarn.lock
markov00
added a commit
to nickofthyme/kibana
that referenced
this pull request
Dec 20, 2021
The commit fixes the Lens heatmap time axis when used with calendars time intervals in date_histogram aggs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The PR will introduce a fix from
elastic-chartsadd the ability to use both calendars and fixed intervals as described in Elasticserach date_histogram aggregationThis fix was required to cover the Lens usage when calendar intervals are used in conjunction with the date_histogram aggs.
In ML Swimlane, the fix only covers the API changes in elastic-charts but doesn't cause any differences in the chart behaviour.
To do: