Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky enter spaces tests #117510

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Fix flaky enter spaces tests #117510

merged 2 commits into from
Nov 9, 2021

Conversation

thomheymann
Copy link
Contributor

@thomheymann thomheymann commented Nov 4, 2021 •
edited
Loading

@thomheymann thomheymann added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.1.0 labels Nov 4, 2021
@thomheymann thomheymann requested a review from a team November 4, 2021 13:07
@thomheymann thomheymann marked this pull request as ready for review November 8, 2021 10:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@thomheymann
Copy link
Contributor Author

Flaky test runner passes (the 2 failed builds are due to unrelated functional tests in lens)

@thomheymann
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jportner
jportner approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (see #100570 (comment))

@thomheymann thomheymann merged commit 1837e4a into elastic:main Nov 9, 2021
@jportner
Copy link
Contributor

jportner commented Nov 9, 2021

@thomheymann seeing as this started failing in CI, let's hold off on backporting

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 11, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 117510 or prevent reminders by adding the backport:skip label.

3 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 117510 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 117510 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 117510 or prevent reminders by adding the backport:skip label.

@jportner
Copy link
Contributor

The test is still flaky and the linked issue has been reopened.

@jportner jportner added the backport:skip This commit does not require backporting label Nov 16, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jportner jportner jportner approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
4 participants
@thomheymann @elasticmachine @kibanamachine @jportner