Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alerting] Add more rule execution context #117504
[Alerting] Add more rule execution context #117504
Changes from 1 commit
d300657
8cfb1c8
6ac6e4a
d82047a
ed7a004
ba9995e
b99d0c2
51901da
9c51b78
39d2a35
04a0f6d
d9d0700
cb46022
8528192
edf303d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The valid status values for this field are here:
kibana/x-pack/plugins/alerting/common/alert.ts
Lines 24 to 25 in 7c8b6b6
pending
means it hasn't run yet, so should never go through this path.unknown
indicates some unexpected issue, so should probably be categorized as 'failure'.active
is a flavor ofok
- the difference between the two isactive
indicates there are active alert instances,ok
indicates there are not (the last run did not schedule any alert instances). Soactive
should also be listed assuccess
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handled both suggested cases 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following our updated terminology, I believe this should be
alerting_new_alerts
,alerting_active_alerts
,alerting_recovered_alerts