[File data visualizer] Disabling create data view based on capabilities #117347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
review
non-issue
|
Pinging @elastic/ml-ui (:ml) |
pheyos
reviewed
Nov 3, 2021
...ata_visualizer/public/application/file_data_visualizer/components/import_view/import_view.js
Outdated
Show resolved
Hide resolved
szabosteve
reviewed
Nov 3, 2021
| showTooltip ? ( | ||
| <FormattedMessage | ||
| id="xpack.dataVisualizer.file.cannotCreateDataView.tooltip" | ||
| defaultMessage="You require permission to create data views" |
There was a problem hiding this comment.
Minor suggestion
Suggested change
| defaultMessage="You require permission to create data views" | |
| defaultMessage="You need permission to create data views" |
There was a problem hiding this comment.
Updated in 93f540c
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
peteharverson
approved these changes
Nov 4, 2021
jgowdyelastic
deleted the
disabling-create-data-view-based-on-capabilities
branch
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 4, 2021
…es (elastic#117347) * [File data visualizer] Disabling create data view based on capabilities * removing data view management card based on permissions * fixing reset button and index data viz link
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Nov 4, 2021
…es (#117347) (#117520) * [File data visualizer] Disabling create data view based on capabilities * removing data view management card based on permissions * fixing reset button and index data viz link Co-authored-by: James Gowdy <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user does not have permission to create index patterns, we should disable the option in the UI.
Also removes the link to manage data views if the user does not have permission.
Also removes link to the index data visualizer if the index pattern hasn't been created. (ML only)