Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Add deprecation level to all fleet deprecations #117332

Merged
merged 1 commit into from
Nov 4, 2021
Merged

[Fleet] Add deprecation level to all fleet deprecations #117332

merged 1 commit into from
Nov 4, 2021

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Nov 3, 2021

Summary

Part of #115344, we need to set the log level for all of our deprecations. critical is the default which we have been using up until now so I am continuing with that level.

@hop-dev hop-dev added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 v8.1.0 labels Nov 3, 2021
@hop-dev hop-dev self-assigned this Nov 3, 2021
@hop-dev hop-dev requested a review from a team as a code owner November 3, 2021 14:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

kpollich
kpollich approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

@hop-dev hop-dev merged commit 0f4aceb into elastic:main Nov 4, 2021
@hop-dev hop-dev deleted the 115344-fleet-specify-deprecation-level branch November 4, 2021 09:56
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 4, 2021
@hop-dev @kibanamachine
add critical level to all fleet deprecations (elastic#117332)
f2cc5ad
@kibanamachine kibanamachine mentioned this pull request Nov 4, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 4, 2021
@hop-dev @kibanamachine
add critical level to all fleet deprecations (elastic#117332)
d5da444
@kibanamachine kibanamachine mentioned this pull request Nov 4, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0
✅ 7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 4, 2021
@kibanamachine @hop-dev
add critical level to all fleet deprecations (#117332) (#117477)
e620fec 
Co-authored-by: Mark Hopkin <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 4, 2021
@kibanamachine @hop-dev
add critical level to all fleet deprecations (#117332) (#117478)
0f9e0b0 
Co-authored-by: Mark Hopkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpollich kpollich kpollich approved these changes

Assignees

@hop-dev hop-dev

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hop-dev @elasticmachine @kibanamachine @kpollich