[Task Manager] Removing perf_hooks from task manager #117294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymao1
added
Feature:Task Manager
release_note:skip
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @ymao1 |
ymao1
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 3, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 3, 2021
|
Tested this PR branch with 200 rules at 1s, 100 workers, 1s polling, to try to force more tasks to be run. Too soon to tell for sure, but it appears that it's not leaking compared to a similar test with main. We'll be doing some days-long testing on this when it becomes available in BC3. |
kibanamachine
added a commit
that referenced
this pull request
Nov 3, 2021
Co-authored-by: ymao1 <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 3, 2021
Co-authored-by: ymao1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #116636
Summary
Removed
perf_hooksfrom task manager. There were not used for anything and, as of Node 16.7, were potentially causing a memory leak because they were not being cleared.