Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Fixes duplicated descriptions in the APM integration settings #117258

Merged
merged 2 commits into from
Nov 3, 2021
Merged

[APM] Fixes duplicated descriptions in the APM integration settings #117258

merged 2 commits into from
Nov 3, 2021

Conversation

ogupte
Copy link
Contributor

@ogupte ogupte commented Nov 3, 2021

Fixes #115692.

Screen Shot 2021-11-03 at 2 17 37 AM
Screen Shot 2021-11-03 at 2 17 43 AM

@ogupte ogupte added release_note:fix auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Nov 3, 2021
@ogupte ogupte requested a review from a team as a code owner November 3, 2021 06:21
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Nov 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@ogupte
Copy link
Contributor Author

ogupte commented Nov 3, 2021

@elasticmachine merge upstream

cauemarcondes
cauemarcondes approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.7MB 2.7MB +54.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ogupte ogupte merged commit cf61e34 into elastic:main Nov 3, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 3, 2021
@ogupte @kibanamachine
[APM] Fixes duplicated descriptions in the APM integration settings (e…
cfca484 
…lastic#115692) (elastic#117258)

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Nov 3, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.16

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 3, 2021
@kibanamachine @ogupte
[APM] Fixes duplicated descriptions in the APM integration settings (#…
85bd04d 
…115692) (#117258) (#117354)

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Oliver Gupte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauemarcondes cauemarcondes cauemarcondes approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:fix Team:APM All issues that need APM UI Team support v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Duplicated descriptions in APM integration
4 participants
@ogupte @elasticmachine @kibanamachine @cauemarcondes