[Visualize] Fixes wrong header menu when navigating from a dashboard to a by ref viz #117077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
changed the title
stratoula
changed the title
stratoula
added
Feature:Visualizations
|
Pinging @elastic/kibana-vis-editors (Team:VisEditors) |
|
@elasticmachine merge upstream |
mbondyra
approved these changes
Nov 3, 2021
stratoula
added
the
auto-backport
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 3, 2021
…to a by ref viz (elastic#117077) * [Visualize] fixes share inactive button when navigating from a dashboard to a by ref vz * Add unit test * Remove the hardcoded 'dashboards' Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 3, 2021
…to a by ref viz (elastic#117077) * [Visualize] fixes share inactive button when navigating from a dashboard to a by ref vz * Add unit test * Remove the hardcoded 'dashboards' Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 3, 2021
…to a by ref viz (#117077) (#117322) * [Visualize] fixes share inactive button when navigating from a dashboard to a by ref vz * Add unit test * Remove the hardcoded 'dashboards' Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Stratoula Kalafateli <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 3, 2021
…to a by ref viz (#117077) (#117324) * [Visualize] fixes share inactive button when navigating from a dashboard to a by ref vz * Add unit test * Remove the hardcoded 'dashboards' Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #116927
This fixes the wrong menu that appears for the by reference visualizations (saved to the library).
This is broken on 7.15 but I can't find the PR that broke it. I added a unit test which will ensure that this won't break in the future.
Specifically:
Save asSave to librarySaveChecklist