Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update osquery page for changes in 7.16 #117031

Merged
merged 11 commits into from
Nov 22, 2021

Conversation

melissaburpo
Copy link
Contributor

@melissaburpo melissaburpo commented Nov 1, 2021

Summary

This PR updates the Osquery doc for the 7.16 release. For details of the updates, see the related issue below.

Preview:
https://kibana_117031.docs-preview.app.elstc.co/guide/en/kibana/master/osquery.html

Related issue

@melissaburpo melissaburpo added release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0 labels Nov 1, 2021
@melissaburpo melissaburpo requested a review from a team November 1, 2021 23:10
@melissaburpo
Copy link
Contributor Author

Hi @aleksmaus, @patrykkopycinski, @james-elastic - this is an early draft of doc changes for 7.16. Can you all please do a technical review, before we pass it off to the docs team for some more general edits? Thanks for any feedback!

docs/osquery/osquery.asciidoc Outdated Show resolved Hide resolved
docs/osquery/osquery.asciidoc Show resolved Hide resolved
docs/osquery/osquery.asciidoc Outdated Show resolved Hide resolved
@melissaburpo melissaburpo requested a review from gchaps November 10, 2021 00:28
@melissaburpo
Copy link
Contributor Author

Hi @gchaps - There may be a few more minor changes coming, but overall, I think this is ready for review!

A few questions:

  • Should I add any other Kibana writers to the review?
  • Can you confirm whether I've applied the correct labels to this PR? I want to make sure this update is included for the 7.16 release docs as well as going forward into 8.0.

Thanks for any tips!

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@gchaps
Copy link
Contributor

gchaps commented Nov 10, 2021

@elasticmachine merge upstream


* Run live queries for one or more agents
* Schedule queries to capture changes to OS state over time
* Schedule query packs to capture changes to OS state over time
* View a history of past queries and their results
* Save queries and build a library of queries for specific use cases
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence appears after the bulleted list. but it doesn't seem to fit in with the flow of the text. Can it be removed?

Osquery results are stored in Elasticsearch, so that you can search, analyze, and visualize Osquery data in Kibana.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's an important thing to note somewhere, because we've received some questions about it. But I definitely see your point. I'll try to find a better spot for it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up moving it to the "Osquery results" section - seems like a better fit there.

docs/osquery/osquery.asciidoc Outdated Show resolved Hide resolved
@@ -51,14 +51,15 @@ and you'll get suggestions for agents by name, ID, platform, and policy.
[role="screenshot"]
image::images/enter-query.png[Select saved query dropdown name showing query name and description]

. (Optional) Expand the **Advanced** section to view or set <<osquery-map-fields,mapped ECS fields>>. The results from the live query include the mapped fields.

. Click **Submit**.

. Review the results in a table, or navigate to *Discover* to dive deeper into the response,
or to the drag-and-drop *Lens* editor to create visualizations.
. To view more information about the request, such as failures, open the *Status* tab.
. To optionally save the query for future use, click *Save for later* and define the ID,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove "optionally" from this sentence for consistency.

. Click **Submit**.

. Review the results in a table, or navigate to *Discover* to dive deeper into the response,
or to the drag-and-drop *Lens* editor to create visualizations.
. To view more information about the request, such as failures, open the *Status* tab.
. To optionally save the query for future use, click *Save for later* and define the ID,
description, and other
<<osquery-manage-query,details>>.
description, and other <<osquery-manage-query,details>>.

To view a history of the past queries you have run, open the *Live queries history*.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be step 10?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up making it an independent sub-section, because I think it's a bit of a separate process from running a live query. Take a look and let me know whether you think the latest update works.

docs/osquery/osquery.asciidoc Outdated Show resolved Hide resolved
docs/osquery/osquery.asciidoc Outdated Show resolved Hide resolved

. To save changes to the query, click *Save*.
** **Osquery value**: Select an Osquery field. The fields available are based on the SQL query entered, and only include fields that the query returns. When the query runs, the ECS field is set dynamically to the value of the osquery field selected.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

osquery field selected > Osquery field selected?


* The unique identifier.
Note:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use our NOTE format. Instructions are here.

docs/osquery/osquery.asciidoc Outdated Show resolved Hide resolved
docs/osquery/osquery.asciidoc Outdated Show resolved Hide resolved
docs/osquery/osquery.asciidoc Outdated Show resolved Hide resolved
docs/osquery/osquery.asciidoc Outdated Show resolved Hide resolved
you can create roles for users who can only run live or saved queries, but who cannot save or schedule queries.
This is useful for teams who need in-depth and detailed control.

[float]
== Upgrade Osquery versions
=== Customize Osquery configuration
By default, all Osquery Manager integrations share the same osquery configuration. However, you can customize how osquery is configured by editing the Osquery Manager integration for each agent policy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

osquery is lowercase here. Is that ok?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to just be consistent throughout and use caps in all instances.

docs/osquery/osquery.asciidoc Outdated Show resolved Hide resolved
docs/osquery/osquery.asciidoc Outdated Show resolved Hide resolved
docs/osquery/osquery.asciidoc Outdated Show resolved Hide resolved
docs/osquery/osquery.asciidoc Outdated Show resolved Hide resolved

* Some fields are protected and cannot be set. A warning is displayed with details about which fields should be removed.

* (Optional) To load a full configuration file, drag and drop an osquery `.conf` file into the area at the bottom of the page.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

osquery lower case?

@elastic elastic deleted a comment from kibanamachine Nov 11, 2021
@gchaps
Copy link
Contributor

gchaps commented Nov 12, 2021

@elasticmachine merge upstream

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments.

docs/osquery/osquery.asciidoc Outdated Show resolved Hide resolved
Optionally, set the minimum Osquery version and platform,
or <<osquery-map-fields,map ECS fields>>. When you add a saved query to a pack, this adds a copy of the query. A connection is not maintained between saved queries and packs.

* To upload queries from a .conf query pack, drag the pack to the drop zone under the query table. To explore the community packs that Osquery publishes, click *Example packs*.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should conf be in a different font: .conf?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed - updated


. Click *Test configuration* to test the query and any mapped fields:

* From the *Test query* panel, select agents or groups to test the query, then click *Submit*. This runs a live query. Result columns that are mapped are marked with image:images/mapped-icon.png[mapping icon]. Hover over the icon to see the mapped ECS field.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The period after to icon wraps to the next line. Not sure how to fix other than to remove a word. You could do "then click Submit to run a live query.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gchaps - did the update commit fix what you were seeing? Thanks!

@gchaps
Copy link
Contributor

gchaps commented Nov 22, 2021

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@melissaburpo melissaburpo merged commit 90fdbf4 into elastic:main Nov 22, 2021
@melissaburpo melissaburpo deleted the update-osquery-doc branch November 22, 2021 21:41
gchaps added a commit to gchaps/kibana that referenced this pull request Nov 22, 2021
* update usage section for changes to live queries, saved queries, packs, and ECS mapping

* add info about custom configuration, ECS mapping for date fields, custom tables, and other copy edits

* address pr comment, add info about static values for ecs mapping, make other minor copy edits

* add more info about the new k8s tables

* Apply suggestions from code review

Co-authored-by: gchaps <[email protected]>

* update per code review comments

* Update docs/osquery/osquery.asciidoc

Co-authored-by: gchaps <[email protected]>

* address review comments

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: gchaps <[email protected]>
gchaps added a commit to gchaps/kibana that referenced this pull request Nov 22, 2021
* update usage section for changes to live queries, saved queries, packs, and ECS mapping

* add info about custom configuration, ECS mapping for date fields, custom tables, and other copy edits

* address pr comment, add info about static values for ecs mapping, make other minor copy edits

* add more info about the new k8s tables

* Apply suggestions from code review

Co-authored-by: gchaps <[email protected]>

* update per code review comments

* Update docs/osquery/osquery.asciidoc

Co-authored-by: gchaps <[email protected]>

* address review comments

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: gchaps <[email protected]>
gchaps added a commit that referenced this pull request Nov 22, 2021
* update usage section for changes to live queries, saved queries, packs, and ECS mapping

* add info about custom configuration, ECS mapping for date fields, custom tables, and other copy edits

* address pr comment, add info about static values for ecs mapping, make other minor copy edits

* add more info about the new k8s tables

* Apply suggestions from code review

Co-authored-by: gchaps <[email protected]>

* update per code review comments

* Update docs/osquery/osquery.asciidoc

Co-authored-by: gchaps <[email protected]>

* address review comments

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: gchaps <[email protected]>

Co-authored-by: Melissa Burpo <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
gchaps added a commit that referenced this pull request Nov 22, 2021
* update usage section for changes to live queries, saved queries, packs, and ECS mapping

* add info about custom configuration, ECS mapping for date fields, custom tables, and other copy edits

* address pr comment, add info about static values for ecs mapping, make other minor copy edits

* add more info about the new k8s tables

* Apply suggestions from code review

Co-authored-by: gchaps <[email protected]>

* update per code review comments

* Update docs/osquery/osquery.asciidoc

Co-authored-by: gchaps <[email protected]>

* address review comments

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: gchaps <[email protected]>

Co-authored-by: Melissa Burpo <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
* update usage section for changes to live queries, saved queries, packs, and ECS mapping

* add info about custom configuration, ECS mapping for date fields, custom tables, and other copy edits

* address pr comment, add info about static values for ecs mapping, make other minor copy edits

* add more info about the new k8s tables

* Apply suggestions from code review

Co-authored-by: gchaps <[email protected]>

* update per code review comments

* Update docs/osquery/osquery.asciidoc

Co-authored-by: gchaps <[email protected]>

* address review comments

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: gchaps <[email protected]>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
* update usage section for changes to live queries, saved queries, packs, and ECS mapping

* add info about custom configuration, ECS mapping for date fields, custom tables, and other copy edits

* address pr comment, add info about static values for ecs mapping, make other minor copy edits

* add more info about the new k8s tables

* Apply suggestions from code review

Co-authored-by: gchaps <[email protected]>

* update per code review comments

* Update docs/osquery/osquery.asciidoc

Co-authored-by: gchaps <[email protected]>

* address review comments

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: gchaps <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants