Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SECURITY] Flaky api keys grid #116991

Merged
merged 10 commits into from
Nov 4, 2021
Merged

[SECURITY] Flaky api keys grid #116991

merged 10 commits into from
Nov 4, 2021

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Nov 1, 2021

Summary

Failing test: Jest Tests.x-pack/plugins/security/public/management/api_keys/api_keys_grid - APIKeysGridPage
Resolve: #97085

Checklist

Delete any items that are not applicable to this PR.

Checklist

@XavierM XavierM added chore Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 v8.1.0 labels Nov 1, 2021
@XavierM XavierM self-assigned this Nov 1, 2021
@XavierM XavierM requested a review from a team as a code owner November 1, 2021 16:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

thomheymann
thomheymann reviewed Nov 1, 2021
View reviewed changes
Copy link
Contributor

@thomheymann thomheymann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for tackling these.

Couple comments below.

x-pack/plugins/security/public/management/api_keys/api_keys_grid/api_keys_grid_page.test.tsx Show resolved Hide resolved
x-pack/test/functional/page_objects/api_keys_page.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/public/management/api_keys/api_keys_grid/api_keys_grid_page.tsx Outdated Show resolved Hide resolved
x-pack/test/functional/apps/api_keys/home_page.ts Outdated Show resolved Hide resolved
x-pack/test/functional/page_objects/api_keys_page.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/public/management/api_keys/api_keys_grid/api_keys_grid_page.test.tsx Show resolved Hide resolved
@azasypkin
Copy link
Member

Thanks a lot for fixing these! Just wanted to note that we have a nice Flaky Test Runner, it would be great if you can schedule a 30-40x run there too before merging 🙂

@XavierM
Copy link
Contributor Author

XavierM commented Nov 2, 2021

Thanks a lot for fixing these! Just wanted to note that we have a nice Flaky Test Runner, it would be great if you can schedule a 30-40x run there too before merging 🙂

I always did it in the last two PRs but it still gave me false indication since all the test in edit user passed through the flaky-test-suite-runner and then failed in CI.

@azasypkin
Copy link
Member

I always did it in the last two PRs but it still gave me false indication since all the test in edit user passed through the flaky-test-suite-runner and then failed in CI.

That's weird, but good to know, thanks. Let's see if it happens this time too, and if so we'll try to figure this out together with the Operations team. We heavily relied on the flaky test runner results in the past and we should make sure it'll stay a strong indication of the stable tests in the future too.

@XavierM
Copy link
Contributor Author

XavierM commented Nov 2, 2021 •
edited
Loading

Jest tests -> https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/2120/

Result: No Failure 🟢

@XavierM
Copy link
Contributor Author

XavierM commented Nov 2, 2021 •
edited
Loading

Functional tests - xpack - ciGroup7 -
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/2121/

Result: No Failure for these new tests 🟢

image

@XavierM XavierM requested a review from thomheymann November 3, 2021 16:42
@XavierM
Copy link
Contributor Author

XavierM commented Nov 3, 2021

@elasticmachine merge upstream

@XavierM
Copy link
Contributor Author

XavierM commented Nov 4, 2021

@elasticmachine merge upstream

@XavierM
Copy link
Contributor Author

XavierM commented Nov 4, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
security 486.9KB 487.1KB +263.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @XavierM

thomheymann
thomheymann approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@thomheymann thomheymann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙌

@XavierM XavierM merged commit b0110d8 into elastic:main Nov 4, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 4, 2021
@XavierM @kibanamachine
[SECURITY] Flaky api keys grid (elastic#116991)
756eaf3 
* fix flaky test + adding functional test

* review + remove more jest flaky test

* fix type

* fix review/confusion

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Nov 4, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 4, 2021
@XavierM @kibanamachine
[SECURITY] Flaky api keys grid (elastic#116991)
145de06 
* fix flaky test + adding functional test

* review + remove more jest flaky test

* fix type

* fix review/confusion

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Nov 4, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0
✅ 7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 4, 2021
@kibanamachine @XavierM
[SECURITY] Flaky api keys grid (#116991) (#117560)
6cd0dc3 
* fix flaky test + adding functional test

* review + remove more jest flaky test

* fix type

* fix review/confusion

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Xavier Mouligneau <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 4, 2021
@kibanamachine @XavierM
[SECURITY] Flaky api keys grid (#116991) (#117561)
e839481 
* fix flaky test + adding functional test

* review + remove more jest flaky test

* fix type

* fix review/confusion

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Xavier Mouligneau <[email protected]>
@legrego legrego mentioned this pull request May 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomheymann thomheymann thomheymann approved these changes

Assignees

@XavierM XavierM

Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
5 participants
@XavierM @elasticmachine @azasypkin @kibanamachine @thomheymann