Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] E2E script improvements #116972

Merged
merged 5 commits into from
Nov 4, 2021
Merged

[APM] E2E script improvements #116972

merged 5 commits into from
Nov 4, 2021

Conversation

sorenlouv
Copy link
Member

@sorenlouv sorenlouv commented Nov 1, 2021 •
edited
Loading

  • Avoid restarting server when updating tests and test configs
  • pass --spec command to cypress runner (Cypress docs)
  • forward --bail flag to ftr
  • Minor cleanup

@sorenlouv sorenlouv requested review from a team as code owners November 1, 2021 15:39
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Nov 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv sorenlouv added auto-backport Deprecated - use backport:version if exact versions are needed v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Nov 1, 2021
@sorenlouv
Copy link
Member Author

@elasticmachine merge upstream

@sorenlouv sorenlouv force-pushed the apm-e2e-script-improvements branch from 515139b to ddd962c Compare November 3, 2021 22:25
MiriamAparicio
MiriamAparicio approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sorenlouv sorenlouv enabled auto-merge (squash) November 4, 2021 12:27
@sorenlouv sorenlouv merged commit 2e35260 into elastic:main Nov 4, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.1.0

If any of these should not be on your pull request, please manually remove them.

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 4, 2021
@sorenlouv @kibanamachine
[APM] E2E script improvements (elastic#116972)
34e3576
@kibanamachine kibanamachine mentioned this pull request Nov 4, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0

This backport PR will be merged automatically after passing CI.

@sorenlouv sorenlouv deleted the apm-e2e-script-improvements branch November 4, 2021 15:17
kibanamachine added a commit that referenced this pull request Nov 4, 2021
@kibanamachine @sorenlouv
[APM] E2E script improvements (#116972) (#117526)
646bf77 
Co-authored-by: Søren Louv-Jansen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiriamAparicio MiriamAparicio MiriamAparicio approved these changes

@jbudz jbudz jbudz approved these changes

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sorenlouv @elasticmachine @kibanamachine @dgieselaar @jbudz @MiriamAparicio