-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show telemetry opt-in/out notice when it has been disabled via yml config. #116867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeelmers
added
Feature:Telemetry
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
auto-backport
Deprecated - use backport:version if exact versions are needed
v7.16.0
v8.1.0
v7.15.2
labels
Oct 29, 2021
@elasticmachine merge upstream |
lukeelmers
added
the
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
label
Oct 31, 2021
Pinging @elastic/kibana-core (Team:Core) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @lukeelmers |
pgayvallet
approved these changes
Nov 1, 2021
TinaHeiligers
approved these changes
Nov 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 1, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 1, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 1, 2021
kibanamachine
added a commit
that referenced
this pull request
Nov 1, 2021
…yml config. (#116867) (#117041) Co-authored-by: Luke Elmers <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 1, 2021
…yml config. (#116867) (#117039) Co-authored-by: Luke Elmers <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 2, 2021
…yml config. (#116867) (#117040) Co-authored-by: Luke Elmers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
Feature:Telemetry
release_note:skip
Skip the PR/issue when compiling release notes
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
v7.15.2
v7.16.0
v8.0.0
v8.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #110638
This fixes an issue where a link to opt out of telemetry was provided from the welcome screen even when
telemetry.allowChangingOptInStatus
was set tofalse
in thekibana.yml
. This created a confusing experience for super users, because they still had access to stack management, but were unable to access the actual setting for changing the opt in status due to theallowChangingOptInStatus
disabling it.To test:
Screenshots:
Before
After (note the fine print is missing opt in/out link)