Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show telemetry opt-in/out notice when it has been disabled via yml config. #116867

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

lukeelmers
Copy link
Member

@lukeelmers lukeelmers commented Oct 29, 2021

Partially addresses #110638

This fixes an issue where a link to opt out of telemetry was provided from the welcome screen even when telemetry.allowChangingOptInStatus was set to false in the kibana.yml. This created a confusing experience for super users, because they still had access to stack management, but were unable to access the actual setting for changing the opt in status due to the allowChangingOptInStatus disabling it.

To test:

# Should display link if logging in with super user (`elastic / changeme`)
telemetry.enabled: true
telemetry.allowChangingOptInStatus: true

# Should not display link
telemetry.enabled: true
telemetry.allowChangingOptInStatus: false

Screenshots:

Before
Screen Shot 2021-10-31 at 3 11 37 PM

After (note the fine print is missing opt in/out link)
Screen Shot 2021-10-31 at 3 12 30 PM

@lukeelmers lukeelmers added Feature:Telemetry v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 v8.1.0 v7.15.2 labels Oct 29, 2021
@lukeelmers lukeelmers self-assigned this Oct 29, 2021
@lukeelmers
Copy link
Member Author

@elasticmachine merge upstream

@lukeelmers lukeelmers marked this pull request as ready for review October 31, 2021 21:15
@lukeelmers lukeelmers requested a review from a team as a code owner October 31, 2021 21:15
@lukeelmers lukeelmers added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Oct 31, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
home 76.2KB 76.2KB +47.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lukeelmers

Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0
7.16
7.15

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 1, 2021
kibanamachine added a commit that referenced this pull request Nov 1, 2021
kibanamachine added a commit that referenced this pull request Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.15.2 v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants