[Security Solution] [Sourcerer] Store and type cleanup

[stephmilovic]

Summary

Let's merge this into elastic:sourcerer_kip_as to make life easier, double bug fixing is not ideal.

Closes https://github.com/elastic/security-team/issues/1730

1. Moves data view related field state from sourcererScopes to kibanaDataViews
2. enhances the useSourcererScope => now renamed to useSourcererDataView which combines the redux state of the sourcererScope and its corresponding kibanaDataView to get the active SourcererDataView
3. Updates the deprecated IIndexPattern type to DataViewBase

[elasticmachine]

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

[elasticmachine]

Pinging @elastic/security-solution (Team: SecuritySolution)

[angorayc]

signalIndexNameSourcerer seems could be null, although I guess defaultDataView.title could never includes null string, it just a bit weird to covert null to string.

[stephmilovic]

yes its for a type reason, cant check if a string includes null

[angorayc]

Could you please give me an example of how it happen in UI between Line86-90?

[stephmilovic]

Ok I renamed signalIndexNameSelector to signalIndexNameSourcerer so maybe that will help.

if the signal index is not loading, the signalIndexName is defined in useSignalIndex, but the signalIndexNameSourcerer has not been defined. This can happen the first time signal index is created. We also check to make sure that the Timeline sourcerer isn't already initiated and that default exists. Does that help?

    if (
      !loadingSignalIndex &&
      signalIndexName != null &&
      signalIndexNameSourcerer == null &&
      (activeTimeline == null || activeTimeline.savedObjectId == null) &&
      initialTimelineSourcerer.current &&
      defaultDataView.id.length > 0
    )

[kibanamachine]

💔 Build Failed

• Buildkite Build
• Commit: 718e14e
• Interpreting CI Failures
• Storybooks Preview

Failed CI Steps

• Post-Build

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [8286a33]

History

• 💔 Build #4184 failed 141342e
• 💔 Build #4168 failed d6c81d5
• 💔 Build #3680 failed 485bb11
• 💔 Build #3477 failed 9c25ac9
• 💔 Build #2979 failed ec20b33

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream