[Fleet] Fix branch conditions to check against main and add skip version check config option
#116530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jen-huang
added
chore
v8.0.0
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
juliaElastic
approved these changes
Oct 28, 2021
|
@elasticmachine merge upstream |
joshdover
approved these changes
Oct 28, 2021
|
Taking over this PR to fix Kibana CI due issue with EPR on 8.0.0 |
|
Thanks @joshdover! |
| @@ -57,8 +57,8 @@ export const createAppContextStartContractMock = (): MockedFleetAppContext => { | |||
| agentIdVerificationEnabled: true, | |||
| }, | |||
| config$, | |||
| kibanaVersion: '8.0.0', | |||
| kibanaBranch: 'master', | |||
| kibanaVersion: '8.99.0', // Fake version :) | |||
There was a problem hiding this comment.
At least until ~2030 ;-)
jen-huang
changed the title
mainmain and add skip version check config option
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 29, 2021
…rsion check config option (elastic#116530)
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates some conditions in Fleet which check against the branch name. Do not merge until default branch in this repo has been renamed to
mainas well.This also adds the config option
xpack.fleet.developer.disableRegistryVersionCheckthat enables bypassing of Kibana version constraints on requests to EPR. This is currentlytrueby default until 8.0 packages are published and tests which depend on those packages are able to pass without bypassing version check (#102283, #102282, #116522).