Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Add overrides for request parameters for Logstash PUT Pipeline API #116450

Merged
merged 13 commits into from
Nov 18, 2021

Conversation

vladpro25
Copy link
Contributor

@vladpro25 vladpro25 commented Oct 27, 2021

Closes: #91739

Introduction

Issue: [Console] Add overrides for request parameters for Logstash PUT Pipeline API #91739

Brief description of the issue

This issue is a follow up to #90904 to add the overrides for the Logstash PUT Pipeline API.
There is an issue to add the parameter definitions to the docs and once that has been updated, we will add those default values to our Autocomplete definitions via overrides.

Final result

Overrides have been added for query parameters for the Logstash PUT Pipeline API

Confirmation

image

Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally

image

@alexwizp
Copy link
Contributor

@elasticmachine merge upstream

@alexwizp
Copy link
Contributor

@elasticmachine merge upstream

@alexwizp alexwizp requested a review from cjcenizal October 28, 2021 14:09
@alexwizp
Copy link
Contributor

@elasticmachine merge upstream

Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on these autocomplete definitions, @vladpro25!
I left a couple of comments below for pipeline_metadata and pipeline_settings. Also I think it would be very useful to add __template property at the top level. That could contain the required properties and auto-create an object for user to start editing. Something like

"logstash.put_pipeline": {
    "data_autocomplete_rules": {
      "__template": {
        "last_modified": "",
        "pipeline" : "",
        "pipeline_metadata": {},
        "pipeline_settings": {},
        "username": "",
      },
      "description": ""
      ...
    }
}

@alexwizp
Copy link
Contributor

@elasticmachine merge upstream

@alexwizp alexwizp added Feature:Console Dev Tools Console Feature release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.1.0 Feature:Dev Tools labels Nov 10, 2021
@vladpro25 vladpro25 marked this pull request as ready for review November 16, 2021 12:08
@vladpro25 vladpro25 requested a review from a team as a code owner November 16, 2021 12:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@vladpro25
Copy link
Contributor Author

@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Nov 16, 2021
@vladpro25 vladpro25 requested a review from yuliacech November 16, 2021 18:58
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #5 / saved objects spaces only enabled _bulk_create within the default space should return 200 success [isolatedtype/space1-isolatedtype-id,isolatedtype/space2-isolatedtype-id,dashboard/new-dashboard-id,sharedtype/new-sharedtype-id,globaltype/new-globaltype-id,isolatedtype/new-other-space-id,sharecapabletype/new-other-space-id,sharedtype/new-each-space-id,sharedtype/new-all-spaces-id,resolvetype/alias-match] and bad request [hiddentype/any,isolatedtype/new-other-space-id,sharecapabletype/new-other-space-id] and conflict [isolatedtype/defaultspace-isolatedtype-id,sharedtype/all_spaces,sharedtype/default_and_space_1,sharedtype/only_space_1,sharedtype/only_space_2,sharecapabletype/only_default_space,sharecapabletype/only_space_1,globaltype/globaltype-id,resolvetype/alias-match]

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vladpro25

@vladpro25 vladpro25 requested a review from alexwizp November 17, 2021 11:53
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes LGTM, thanks for patching this up @vladpro25!

Copy link
Contributor Author

@vladpro25 vladpro25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment. I made edits to my changes

@vladpro25 vladpro25 requested review from yuliacech and removed request for yuliacech November 18, 2021 08:29
@vladpro25 vladpro25 merged commit e4621fd into elastic:main Nov 18, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 18, 2021
TinLe pushed a commit to TinLe/kibana that referenced this pull request Nov 20, 2021
…ine API (elastic#116450)

* Autostuggestion for geo_* added...

* Autostuggestion for geo_* added

* Add overrides for request parameters for Logstash PUT Pipeline API

* Add overrides for request parameters for Logstash PUT Pipeline API

* Add overrides for request parameters for Logstash PUT Pipeline API

* Add overrides for request parameters for Logstash PUT Pipeline API

Co-authored-by: Kibana Machine <[email protected]>
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
…ine API (#116450)

* Autostuggestion for geo_* added...

* Autostuggestion for geo_* added

* Add overrides for request parameters for Logstash PUT Pipeline API

* Add overrides for request parameters for Logstash PUT Pipeline API

* Add overrides for request parameters for Logstash PUT Pipeline API

* Add overrides for request parameters for Logstash PUT Pipeline API

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Console Dev Tools Console Feature Feature:Dev Tools release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Console] Add overrides for request parameters for Logstash PUT Pipeline API
7 participants