-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console] Add overrides for request parameters for Logstash PUT Pipeline API #116450
Conversation
src/plugins/console/server/lib/spec_definitions/json/overrides/logstash.put_pipeline.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
src/plugins/console/server/lib/spec_definitions/json/overrides/logstash.put_pipeline.json
Outdated
Show resolved
Hide resolved
src/plugins/console/server/lib/spec_definitions/json/overrides/logstash.put_pipeline.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on these autocomplete definitions, @vladpro25!
I left a couple of comments below for pipeline_metadata
and pipeline_settings
. Also I think it would be very useful to add __template
property at the top level. That could contain the required properties and auto-create an object for user to start editing. Something like
"logstash.put_pipeline": {
"data_autocomplete_rules": {
"__template": {
"last_modified": "",
"pipeline" : "",
"pipeline_metadata": {},
"pipeline_settings": {},
"username": "",
},
"description": ""
...
}
}
@elasticmachine merge upstream |
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @vladpro25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest changes LGTM, thanks for patching this up @vladpro25!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comment. I made edits to my changes
…ine API (elastic#116450) * Autostuggestion for geo_* added... * Autostuggestion for geo_* added * Add overrides for request parameters for Logstash PUT Pipeline API * Add overrides for request parameters for Logstash PUT Pipeline API * Add overrides for request parameters for Logstash PUT Pipeline API * Add overrides for request parameters for Logstash PUT Pipeline API Co-authored-by: Kibana Machine <[email protected]>
…ine API (#116450) * Autostuggestion for geo_* added... * Autostuggestion for geo_* added * Add overrides for request parameters for Logstash PUT Pipeline API * Add overrides for request parameters for Logstash PUT Pipeline API * Add overrides for request parameters for Logstash PUT Pipeline API * Add overrides for request parameters for Logstash PUT Pipeline API Co-authored-by: Kibana Machine <[email protected]>
Closes: #91739
Introduction
Issue: [Console] Add overrides for request parameters for Logstash PUT Pipeline API #91739
Brief description of the issue
This issue is a follow up to #90904 to add the overrides for the Logstash PUT Pipeline API.
There is an issue to add the parameter definitions to the docs and once that has been updated, we will add those default values to our Autocomplete definitions via overrides.
Final result
Overrides have been added for query parameters for the Logstash PUT Pipeline API
Confirmation