Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix anchor link to saved objects migrations testing #116427

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

rudolf
Copy link
Contributor

@rudolf rudolf commented Oct 27, 2021

Summary

Fixes the docs link to saved objects migrations testing.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@rudolf rudolf added docs Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 v7.16.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 27, 2021
@rudolf rudolf marked this pull request as ready for review October 27, 2021 11:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@rudolf rudolf added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 27, 2021
@rudolf rudolf enabled auto-merge (squash) October 27, 2021 11:04
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 27, 2021

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] OSS CI Group #2 / embeddable explorer dashboard container pie charts
  • [job] [logs] OSS CI Group #2 / embeddable explorer dashboard container pie charts

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rudolf rudolf disabled auto-merge October 28, 2021 08:36
@rudolf
Copy link
Contributor Author

rudolf commented Oct 28, 2021

Unrelated CI failure

@rudolf rudolf merged commit 2e4c872 into elastic:master Oct 28, 2021
@rudolf rudolf deleted the fix-dev-docs-link branch October 28, 2021 08:37
@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.1.0

If any of these should not be on your pull request, please manually remove them.

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0
7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 28, 2021
academo pushed a commit to academo/kibana that referenced this pull request Oct 28, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 29, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 29, 2021
rudolf added a commit that referenced this pull request Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed docs release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants