[Security Solution] Security RAC migration follow up bug fixes #116386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshallmain
added
Team: SecuritySolution
|
@elasticmachine merge upstream |
9 tasks
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
marshallmain
added
the
release_note:skip
madirey
reviewed
Oct 27, 2021
| @@ -46,9 +46,10 @@ describe('Alert details with unmapped fields', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| // This test needs to be updated to not look for the field in a specific row, as it prevents us from adding/removing fields | |||
madirey
reviewed
Oct 27, 2021
| @@ -30,7 +30,7 @@ export const createPersistenceRuleTypeWrapper: CreatePersistenceRuleTypeWrapper | |||
| .getWriter({ namespace: options.spaceId }) | |||
| .bulk({ | |||
| body: alerts.flatMap((alert) => [ | |||
| { index: {} }, | |||
| { index: { _id: alert.id } }, | |||
There was a problem hiding this comment.
We can probably unskip some tests due to this fix (but we can do that in a follow-up PR).
20 tasks
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
marshallmain
added
the
auto-backport
|
The following labels were identified as gaps in your version labels and will be added automatically:
If any of these should not be on your pull request, please manually remove them. |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 28, 2021
…ic#116386) * Add compatibility aliases to alerts as data indices * Fix dupe mitigation, allow more fields in mapping * Remove legacy signals fields from new RAC alerts * Fix cypress test * Remove outdated comment * Reduce flakiness in time based test Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
marshallmain
added a commit
that referenced
this pull request
Oct 30, 2021
…) (#116651) * Add compatibility aliases to alerts as data indices * Fix dupe mitigation, allow more fields in mapping * Remove legacy signals fields from new RAC alerts * Fix cypress test * Remove outdated comment * Reduce flakiness in time based test Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Marshall Main <[email protected]>
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
kibana.alert.rule.threat_mapping->kibana.alert.rule.threat_mapping.entries)