[Reporting] Remove Boom
#116289
Merged
[Reporting] Remove Boom
#116289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esponse to forbidden to avoid client logging user out
jloleysens
added
chore
(Deprecated) Feature:Reporting
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
|
@elasticmachine merge upstream |
jloleysens
added
the
auto-backport
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
|
The following labels were identified as gaps in your version labels and will be added automatically:
If any of these should not be on your pull request, please manually remove them. |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 28, 2021
* remove use of boom from info response handler; also changed unauthd response to forbidden to avoid client logging user out * rather return 500 with err.message * added jest tests for common cases on the info route Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 28, 2021
* remove use of boom from info response handler; also changed unauthd response to forbidden to avoid client logging user out * rather return 500 with err.message * added jest tests for common cases on the info route Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 28, 2021
* remove use of boom from info response handler; also changed unauthd response to forbidden to avoid client logging user out * rather return 500 with err.message * added jest tests for common cases on the info route Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Jean-Louis Leysens <[email protected]>
kibanamachine
added
the
backport missing
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
jloleysens
added a commit
that referenced
this pull request
Nov 1, 2021
* remove use of boom from info response handler; also changed unauthd response to forbidden to avoid client logging user out * rather return 500 with err.message * added jest tests for common cases on the info route Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Jean-Louis Leysens <[email protected]>
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes an instance of throwing a Boom.unauthorized error and instead uses the
kibanaResponseFactoryresponses.Notes
ResponseHandleclass and instead returns a 500 with error message that will hopefully provide more information about the issue client side.Checklist