Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fix ip.replace error on Network/HTTP Tab #116288

Merged
merged 7 commits into from
Nov 4, 2021
Merged

[Security Solution] Fix ip.replace error on Network/HTTP Tab #116288

merged 7 commits into from
Nov 4, 2021

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Oct 26, 2021 •
edited
Loading

Summary

Bugfix for: #110844

geo.ip can be string or array, and we were only handling string in network details link component.

Checklist

@stephmilovic stephmilovic added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 Team:Threat Hunting:Explore labels Oct 26, 2021
@stephmilovic stephmilovic requested a review from a team as a code owner October 26, 2021 13:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@MadameSheema
Copy link
Member

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.5MB 4.5MB +177.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stephmilovic stephmilovic merged commit 5eeb5b8 into elastic:main Nov 4, 2021
@stephmilovic stephmilovic deleted the bugfix_110844 branch November 4, 2021 13:30
@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.1.0

If any of these should not be on your pull request, please manually remove them.

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 4, 2021
@stephmilovic @kibanamachine
[Security Solution] Fix ip.replace error on Network/HTTP Tab (elastic…
2ce642e 
…#116288)
@kibanamachine kibanamachine mentioned this pull request Nov 4, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 4, 2021
@stephmilovic @kibanamachine
[Security Solution] Fix ip.replace error on Network/HTTP Tab (elastic…
9a730dc 
…#116288)
@kibanamachine kibanamachine mentioned this pull request Nov 4, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0
✅ 7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 4, 2021
@kibanamachine @stephmilovic
[Security Solution] Fix ip.replace error on Network/HTTP Tab (#116288) (
7601fdc 
#117514)

Co-authored-by: Steph Milovic <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 4, 2021
@kibanamachine @stephmilovic
[Security Solution] Fix ip.replace error on Network/HTTP Tab (#116288) (
c7998c0 
#117515)

Co-authored-by: Steph Milovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamster10 jamster10 jamster10 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stephmilovic @elasticmachine @MadameSheema @kibanamachine @jamster10