Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Anomaly Detection: Functional tests for anomaly detection forecasts. #116140

Merged
merged 7 commits into from
Oct 28, 2021
Merged

[ML] Anomaly Detection: Functional tests for anomaly detection forecasts. #116140

merged 7 commits into from
Oct 28, 2021

Conversation

walterra
Copy link
Contributor

Summary

Part of #110949.

Functional tests for anomaly detection forecasts.

Checklist

@walterra walterra added :ml Feature:Anomaly Detection ML anomaly detection test_xpack_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Oct 25, 2021
@walterra walterra self-assigned this Oct 25, 2021
@walterra walterra requested a review from a team as a code owner October 25, 2021 14:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra walterra mentioned this pull request Oct 25, 2021
Closed
16 tasks
@pheyos
Copy link
Member

pheyos commented Oct 26, 2021 •
edited
Loading

Checking test stability in a flaky test runner job ... no ML failure in 50 runs ✔️ (just one unrelated lens test failure)

@walterra
Copy link
Contributor Author

@pheyos Thanks for the feedback, addressed your comments in 25ecf61.

@walterra walterra requested a review from qn895 October 27, 2021 08:19
pheyos
pheyos approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
Great to get UI test coverage for the forecasting feature!

@walterra
Copy link
Contributor Author

@elasticmachine merge upstream

@walterra
Copy link
Contributor Author

@elasticmachine merge upstream

@qn895
Copy link
Member

qn895 commented Oct 27, 2021

LGTM 🎉

@walterra
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.6MB 3.6MB +260.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 28, 2021
@walterra walterra merged commit 0f73b57 into elastic:master Oct 28, 2021
@walterra walterra deleted the ml-forecast-functional-test branch October 28, 2021 12:18
@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.1.0

If any of these should not be on your pull request, please manually remove them.

@kibanamachine kibanamachine mentioned this pull request Oct 28, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 28, 2021
@walterra @kibanamachine
[ML] Anomaly Detection: Functional tests for anomaly detection foreca…
b10375b 
…sts. (elastic#116140)

Functional tests for anomaly detection forecasts.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 28, 2021
@walterra @kibanamachine
[ML] Anomaly Detection: Functional tests for anomaly detection foreca…
9206be8 
…sts. (elastic#116140)

Functional tests for anomaly detection forecasts.
@kibanamachine kibanamachine mentioned this pull request Oct 28, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0
✅ 7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 28, 2021
@kibanamachine @walterra
[ML] Anomaly Detection: Functional tests for anomaly detection foreca…
8133ee7 
…sts. (#116140) (#116610)

Functional tests for anomaly detection forecasts.

Co-authored-by: Walter Rafelsberger <[email protected]>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 29, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

walterra pushed a commit that referenced this pull request Oct 30, 2021
@kibanamachine
[ML] Anomaly Detection: Functional tests for anomaly detection foreca…
c397556 
…sts. (#116140) (#116609)

Functional tests for anomaly detection forecasts.
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qn895 qn895 qn895 approved these changes

@pheyos pheyos pheyos approved these changes

@peteharverson peteharverson Awaiting requested review from peteharverson

Assignees

@walterra walterra

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@walterra @elasticmachine @pheyos @qn895 @kibanamachine