Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename useUrlParams to useLegacyUrlParams #116062

Merged
merged 8 commits into from
Nov 3, 2021
Merged

chore: rename useUrlParams to useLegacyUrlParams #116062

merged 8 commits into from
Nov 3, 2021

Conversation

luckened
Copy link
Contributor

@luckened luckened commented Oct 23, 2021 •
edited by sorenlouv
Loading

Summary

This addresses the other part of #115161 , let me know if i missed something

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@luckened luckened requested review from a team as code owners October 23, 2021 18:43
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Oct 23, 2021
@kibanamachine kibanamachine added 💝community and removed Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability Team:Fleet Team label for Observability Data Collection Fleet team labels Oct 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@sorenlouv
Copy link
Member

retest

@dominiqueclarke dominiqueclarke self-requested a review October 25, 2021 19:17
justinkambic
justinkambic approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX change LGTM

@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Oct 25, 2021
@sorenlouv
Copy link
Member

@elasticmachine merge upstream

@sorenlouv
Copy link
Member

Buildkite, test this

@sorenlouv
Copy link
Member

@elasticmachine run elasticsearch-ci/docs

@sorenlouv sorenlouv enabled auto-merge (squash) October 26, 2021 09:00
@sorenlouv
Copy link
Member

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv
Copy link
Member

@elasticmachine merge upstream

@sorenlouv
Copy link
Member

Buildkite, test this

@sorenlouv
Copy link
Member

@elasticmachine run elasticsearch-ci/docs

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv
Copy link
Member

@elasticmachine merge upstream

@sorenlouv
Copy link
Member

Buildkite, test this
@elasticmachine run elasticsearch-ci/docs

@sorenlouv sorenlouv merged commit 6c06b12 into elastic:main Nov 3, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 3, 2021
@sorenlouv
Copy link
Member

@luckened Oh wow, I can't believe it took that many retries. I'm embarrassed to be honest but happy to see it merged.
Thank you for your contribution and patience!

@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.1.0

If any of these should not be on your pull request, please manually remove them.

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 3, 2021
@luckened @kibanamachine
chore: rename useUrlParams to useLegacyUrlParams (elastic#116062)
8671cb6 
* chore: rename useUrlParams to useLegacyUrlParams

* fix: revert uptime & fleet changes

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Nov 3, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0

This backport PR will be merged automatically after passing CI.

@luckened
Copy link
Contributor Author

luckened commented Nov 3, 2021

@sqren my pleasure to help! thanks for the support ❤️

kibanamachine added a commit that referenced this pull request Nov 4, 2021
@kibanamachine @luckened
chore: rename useUrlParams to useLegacyUrlParams (#116062) (#117373)
181b042 
* chore: rename useUrlParams to useLegacyUrlParams

* fix: revert uptime & fleet changes

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Lucca Miranda <[email protected]>
@dannycroft dannycroft mentioned this pull request Nov 19, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@juliaElastic juliaElastic juliaElastic approved these changes

@justinkambic justinkambic justinkambic approved these changes

@nchaulet nchaulet nchaulet approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed 💝community release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@luckened @kibanamachine @elasticmachine @sorenlouv @brianseeders @smith @nchaulet @justinkambic @juliaElastic