Improve Visualize screen-reader accessibility. #11599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
force-pushed
the
11520/improvement/visualize-screen-reader-accessibility
branch
from
2215fe5 to
ac86388
Compare
cjcenizal
commented
May 4, 2017
| ng-model="vis.params.setColorRange" | ||
| type="checkbox" | ||
| class="kuiSideBarSectionTitle__action" | ||
| ng-click="toggleColorRangeSection(true)" |
There was a problem hiding this comment.
No changes here, just formatting.
cjcenizal
commented
May 4, 2017
| aria-label="Show labels" | ||
| ng-model="valueAxis.labels.show" | ||
| type="checkbox" | ||
| class="kuiSideBarSectionTitle__action" |
There was a problem hiding this comment.
No changes here, just formatting.
cjcenizal
commented
May 4, 2017
| @@ -5,9 +5,10 @@ | |||
| </div> | |||
|
|
|||
| <button | |||
| aria-label="Add value axis" | |||
| data-test-subj="visualizeAddYAxisButton" | |||
| aria-label="Add Y axis" | |||
There was a problem hiding this comment.
Can you confirm that we should use the term "Y axis" here instead of "value axis"?
cjcenizal
commented
May 4, 2017
| <div css-truncate title="{{indexPattern.id}}" ng-if="vis.type.requiresSearch" class="index-pattern"> | ||
| <div | ||
| css-truncate | ||
| aria-label="{{:: 'Index pattern: ' + indexPattern.id}}" |
There was a problem hiding this comment.
We should use aria-label here instead of title. Because aria-label overrides any text content, we also need to include the index pattern ID here.
cjcenizal
commented
May 4, 2017
| > | ||
| <span | ||
| className="Select-value-label" | ||
| aria-label={`${label} icon`} |
There was a problem hiding this comment.
We should use aria-label instead of title. And to provide context, we'll also append the word "icon".
cjcenizal
commented
May 4, 2017
| @@ -1,6 +1,7 @@ | |||
| export function PointSeriesVisProvider({ getService }) { | |||
| const remote = getService('remote'); | |||
| const config = getService('config'); | |||
| const testSubjects = getService('testSubjects'); | |||
There was a problem hiding this comment.
BTW, I think this file needs to be moved into the page_objects directory.
cjcenizal
added
Team:Platform-Design
tbragin
added
Feature:Visualizations
- Add aria-label to Tile Map visualization's 'Fit Data Bounds' button. - Add aria-label for Visualize Editor sidebar index pattern. - Add aria-label to Time Series Visual Builder Annotation icon options. - Add aria-label for Time Series Visual Builder AggSelectOption. - Add aria-label to Time Series Visual Builder Annotation selected icon option. - Adjust aria-labels for Heatmap visualization options. - Adjust aria-labels for ValueAxes add and remove buttons.
cjcenizal
force-pushed
the
11520/improvement/visualize-screen-reader-accessibility
branch
from
ac86388 to
572f998
Compare
|
jenkins, test this |
cjcenizal
deleted the
11520/improvement/visualize-screen-reader-accessibility
branch
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
May 11, 2017
- Add aria-label to Tile Map visualization's 'Fit Data Bounds' button. - Add aria-label for Visualize Editor sidebar index pattern. - Add aria-label to Time Series Visual Builder Annotation icon options. - Add aria-label for Time Series Visual Builder AggSelectOption. - Add aria-label to Time Series Visual Builder Annotation selected icon option. - Adjust aria-labels for Heatmap visualization options. - Adjust aria-labels for ValueAxes add and remove buttons.
cjcenizal
changed the title
cjcenizal
added a commit
that referenced
this pull request
May 11, 2017
- Add aria-label to Tile Map visualization's 'Fit Data Bounds' button. - Add aria-label for Visualize Editor sidebar index pattern. - Add aria-label to Time Series Visual Builder Annotation icon options. - Add aria-label for Time Series Visual Builder AggSelectOption. - Add aria-label to Time Series Visual Builder Annotation selected icon option. - Adjust aria-labels for Heatmap visualization options. - Adjust aria-labels for ValueAxes add and remove buttons.
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
- Add aria-label to Tile Map visualization's 'Fit Data Bounds' button. - Add aria-label for Visualize Editor sidebar index pattern. - Add aria-label to Time Series Visual Builder Annotation icon options. - Add aria-label for Time Series Visual Builder AggSelectOption. - Add aria-label to Time Series Visual Builder Annotation selected icon option. - Adjust aria-labels for Heatmap visualization options. - Adjust aria-labels for ValueAxes add and remove buttons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #11520. Extracts some work from #11548.