[App Search] Improve visual design of Promoted Documents panel #115683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byronhulcher
added
auto-backport
byronhulcher
commented
Oct 19, 2021
|
|
||
| import { LoadingOverlay } from '../../../shared/loading'; | ||
|
|
||
| import './data_panel.scss'; | ||
|
|
||
| interface Props { | ||
| type Props = Omit<_EuiPanelDivlike, 'title'> & { |
There was a problem hiding this comment.
I'm doing this so I can pass in any arbitrary prop from EuiPanel into DataPanel
| className={classes} | ||
| hasShadow={false} | ||
| aria-busy={isLoading} | ||
| {...props} |
There was a problem hiding this comment.
I move this below so I can pass in a custom color prop that will overwrite the above logic. This is kind of a hack.
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
JasonStoltz
approved these changes
Oct 20, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 20, 2021
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
tylersmalley
pushed a commit
that referenced
this pull request
Oct 20, 2021
…) (#115768) Co-authored-by: Byron Hulcher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a nice blue background and border. I also updated
CurationResultso it will only have space between results (no trailing margin)I recommend hiding whitespace changes while reviewing
Screenshot
Checklist