Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Uptime] Added trends chart and deep link to exp view on waterfall step metric markers (#114068) #115643

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

…ep metric markers (elastic#114068)

* added trend chart and link to exp view

* Added step level filtering/breakdowns

* fix type

* make step and monitor name single select

* fix test

* added step filters

* pr feedback

* hide step filter for non step metrics

* pr feedback

* remove step def when it's not applicable

* ^^also for step name breakdown

* Update x-pack/plugins/observability/public/components/shared/exploratory_view/series_editor/breakdown/breakdowns.tsx

Co-authored-by: Dominique Clarke <[email protected]>

* use side effct

* update monitor filter

* update all_value usage

* refactor

* fix type

* use last value operation

* use last 48 intervals

Co-authored-by: Dominique Clarke <[email protected]>
@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
uptime 664 666 +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 265 267 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 381.5KB 382.5KB +999.0B
uptime 571.0KB 573.2KB +2.2KB
total +3.1KB
Unknown metric groups

API count

id before after diff
observability 266 268 +2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

@kibanamachine kibanamachine merged commit acb8751 into elastic:7.x Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants