-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features integrations + mobile, copy, design tweaks #115495
Changes from 3 commits
72a33c3
2bd148f
1ef8d18
103b77f
de133ad
6273668
a556a6a
414d053
109047c
ad1f3bf
73f885d
4a8cf83
b1f9c62
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -91,7 +91,7 @@ export const EmptyIndexListPrompt = ({ | |
<EuiCard | ||
className="inpEmptyState__card" | ||
onClick={() => { | ||
navigateToApp('home', { path: '/app/integrations/browse' }); | ||
navigateToApp('integrations', { path: '/browse' }); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug from #114911 This fixes the link from the index pattern redirect. |
||
closeFlyout(); | ||
}} | ||
icon={<EuiIcon size="xl" type="database" color="subdued" />} | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any thoughts on applying this
max-height
style regardless if the sticky condition is true? Doing so would avoid the visual "jumpiness" of the menu when transitioning between the non-sticky and sticky modes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a follow up item to track this. I think I have some better ways to do this, but given the FF timing / difficulty around getting stuff merged with tests I'm gonna punt this to a follow PR.
#115696