Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused title attribute from saved-object-finder. #11548

Merged
merged 2 commits into from
May 11, 2017
Merged

Remove unused title attribute from saved-object-finder. #11548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18f87c7
Ensure img elements have alt text where necessary (none do).
cjcenizal May 1, 2017
a4cbcb0
Remove unused title attribute from SavedObjectFinder.
cjcenizal May 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/core_plugins/kibana/public/dashboard/top_nav/add_panel.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

<div class="list-group-item list-group-item--noBorder" ng-switch-when="visualization">
<saved-object-finder
title="Choose a visualization"
use-local-management="true"
type="visualizations"
on-add-new="opts.addNewVis"
Expand All @@ -28,6 +27,10 @@
</div>

<div class="list-group-item list-group-item--noBorder" ng-switch-when="search">
<saved-object-finder title="Choose a search" type="searches" use-local-management="true" on-choose="opts.addSearch"></saved-object-finder>
<saved-object-finder
type="searches"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the title attribute isn't used, so I removed it.

use-local-management="true"
on-choose="opts.addSearch"
></saved-object-finder>
</div>
</div>
1 change: 0 additions & 1 deletion src/core_plugins/kibana/public/visualize/wizard/step_2.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ <h2 class="kuiTitle kuiVerticalRhythm">

<!-- Saved searches -->
<saved-object-finder
title="Saved Searches"
type="searches"
class="wizard-row visualizeWizardSavedObjectFinder kuiVerticalRhythm"
make-url="step2WithSearchUrl"
Expand Down
3 changes: 1 addition & 2 deletions src/ui/public/chrome/directives/global_nav/global_nav_link/global_nav_link.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,11 @@
data-test-subj="appLink"
>
<div class="global-nav-link__icon">
<!-- Empty alt attribute is for accessibility -->
<img
ng-if="icon"
class="global-nav-link__icon-image"
kbn-src="{{ '/' + icon }}"
alt=""
aria-hidden
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image means nothing to screen readers, so we hide it.

>

<span
Expand Down
1 change: 0 additions & 1 deletion src/ui/public/directives/saved_object_finder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ module.directive('savedObjectFinder', function ($location, $injector, kbnUrl, Pr
restrict: 'E',
scope: {
type: '@',
title: '@?',
// optional make-url attr, sets the userMakeUrl in our scope
userMakeUrl: '=?makeUrl',
// optional on-choose attr, sets the userOnChoose in our scope
Expand Down