Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maps] re-enable x-pack/test/functional/apps/maps/documents_source/top_hits·js #115392

Merged
merged 8 commits into from
Oct 26, 2021
Merged

[maps] re-enable x-pack/test/functional/apps/maps/documents_source/top_hits·js #115392

merged 8 commits into from
Oct 26, 2021

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Oct 18, 2021

Fixes #115262

@nreese
Copy link
Contributor Author

nreese commented Oct 18, 2021

Buildkite, test this

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Oct 18, 2021

@elasticmachine merge upstream

@nreese nreese requested a review from brianseeders October 19, 2021 15:28
@nreese nreese marked this pull request as ready for review October 19, 2021 15:28
@nreese nreese requested a review from a team as a code owner October 19, 2021 15:28
@nreese nreese added release_note:skip Skip the PR/issue when compiling release notes [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.16.0 v8.0.0 labels Oct 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Contributor Author

nreese commented Oct 19, 2021 •
edited
Loading

Flaky test runner, https://kibana-ci.elastic.co/view/All/job/kibana+flaky-test-suite-runner/2049/, passed 100 out of 100 runs

@brianseeders
Copy link
Contributor

Was there a separate change that fixed something?

@nreese
Copy link
Contributor Author

nreese commented Oct 19, 2021

Was there a separate change that fixed something?

There have been no changes in maps but the test is stable, see https://kibana-ci.elastic.co/view/All/job/kibana+flaky-test-suite-runner/2049/

@nreese
Copy link
Contributor Author

nreese commented Oct 19, 2021

Failed test in unrelated
Endpoint plugin
│ test metadata api

@nreese
Copy link
Contributor Author

nreese commented Oct 19, 2021

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Oct 19, 2021

unrelated failure in checks-reporter / X-Pack accessibility tests

@nreese
Copy link
Contributor Author

nreese commented Oct 19, 2021

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Oct 20, 2021

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Oct 26, 2021

@elasticmachine merge upstream

@nreese nreese added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 26, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit aa17c1b into elastic:master Oct 26, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.16 Cherrypick failed because the selected commit (aa17c1b) is empty. Did you already backport this commit?

To backport manually run:
node scripts/backport --pr 115392

@nreese nreese removed the v7.16.0 label Oct 26, 2021
@nreese
Copy link
Contributor Author

nreese commented Oct 26, 2021

removed v7.16.0 label because test was only skipped in 8.0.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 28, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 115392 or prevent reminders by adding the backport:skip label.

@nreese nreese added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. auto-backport Deprecated - use backport:version if exact versions are needed labels Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

@brianseeders brianseeders Awaiting requested review from brianseeders

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting buildkite-ci [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@nreese @kibanamachine @elasticmachine @brianseeders @thomasneirynck