-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Connectors][ServiceNow] Default isLegacy
to true for API consumers
#115367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Pinging @elastic/security-threat-hunting-cases (Team:Threat Hunting:Cases) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; however, I think we'll need to update the docs now, to indicate that the isLegacy
flag should be set to false
when creating new connectors. For example, docs/management/connectors/action-types/servicenow.asciidoc
(though I'm not sure exactly which SN connectors need this). Can be done in a follow-up PR ...
Thanks, @pmuellr! I will do it in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5e9e2ef
to
76a6aa5
Compare
Doc changes LGTM, thx! |
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / general / X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts.saved objects tagging - functional tests dashboard integration editing allows to select tags for an existing dashboardStandard Out
Stack Trace
Kibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/ml/jobs/categorization_field_examples·ts.apis Machine Learning jobs Categorization example endpoint - partially valid, more than 75% are nullStandard Out
Stack Trace
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…#115367) (#115905) Co-authored-by: Christos Nasikas <[email protected]>
PR #105440 introduces a new
config
attribute calledisLegacy
to distinguish deprecated connectors and new ones. In this PR the default value was set tofalse
. This is a breaking change as it could potentially break automated tools consuming the connector's API. For that reason, this PR changes the default value totrue
and forces the UI to set theisLegacy
tofalse
when creating new connectors.doc previews: