Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Osquery] Add packs (#107345) #115325

Merged

Conversation

patrykkopycinski
Copy link
Contributor

Backports the following commits to 7.x:

# Conflicts:
#	x-pack/plugins/osquery/public/saved_queries/use_create_saved_query.ts
#	x-pack/plugins/osquery/public/saved_queries/use_update_saved_query.ts
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
osquery 260 266 +6

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1110 1112 +2
osquery 11 10 -1
total +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
osquery 865.6KB 873.1KB +7.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
osquery 7.7KB 7.6KB -103.0B

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id before after diff
osquery-pack - 14 +14
Unknown metric groups

API count

id before after diff
fleet 1210 1212 +2
osquery 11 10 -1
total +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit 0300daf into elastic:7.x Oct 18, 2021
@patrykkopycinski patrykkopycinski deleted the backport/7.x/pr-107345 branch October 18, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants