-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Canvas] Adds support for palette in embeddable function #115278
[Canvas] Adds support for palette in embeddable function #115278
Conversation
40ebca5
to
4671abc
Compare
6b2bc48
to
196b94d
Compare
4671abc
to
dca603d
Compare
7557017
to
f8dbcaf
Compare
dff15e3
to
aec465c
Compare
Pinging @elastic/kibana-presentation (Team:Presentation) |
f8dbcaf
to
34831c5
Compare
c414d23
to
214ba29
Compare
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/ml/jobs/categorization_field_examples·ts.apis Machine Learning jobs Categorization example endpoint - partially valid, more than 75% are nullStandard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
34831c5
to
6a29232
Compare
214ba29
to
0047fc9
Compare
6a29232
to
8ac6d41
Compare
c1d63c3
to
294e377
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM (wasn't able to test it locally cuz my environment is a little messed up at the moment)
I came across an issue where the While trying to fix the bug, I wasn't sure which palette should take priority: the palette configured via the Lens editor or the palette provided via the expression in Canvas. I'm punting on this for now. We can revisit this as a future enhancement, but for now users can configure their Lens color palettes by editing their visualization in the Lens editor. |
c637735
to
780f71c
Compare
x-pack/plugins/canvas/public/components/workpad_app/workpad_app.scss
Outdated
Show resolved
Hide resolved
1834014
to
151ceac
Compare
e0d2b2e
to
3f005a8
Compare
46edbbe
to
dc6a861
Compare
Fixed ts errors
3f005a8
to
3abb10f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💔 Build FailedFailed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Summary
This adds the
palette
argument to theembeddable
function. This argument is only compatible with lens type embeddables, but I added it to maintain feature parity with the existingsavedLens
function.Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers