[Exploratory View] Added step level filtering/breakdowns #115182

shahzad31 · 2021-10-15T12:51:13Z

Summary

User can filter step level metrics using step selection.

User can also do breakdowns by step name

elasticmachine · 2021-10-15T12:53:06Z

Pinging @elastic/uptime (Team:uptime)

drewpost

Did this make the Monitor and Step selections in the definition of the series single select? We really shouldn't have multi-select on these fields

...bservability/public/components/shared/exploratory_view/configurations/constants/constants.ts

drewpost

Looks great. Thanks @shahzad31 !!

dominiqueclarke

Can we hide the step dropdown if ALL_VALUES is selected.

I was unable to break down by step name, even when selecting a specific browser monitor. Edit: this happened, even after I fixed my mappings, but I am unable to recreate now. Also, we may need a popover to explain why breakdown by step name is disabled when unavailable.

We should consider moving fields onto new lines. It's getting crowded, and the flexible layout means that the inputs change size as the user is interacting with them.

When breaking down by step name, we see the step names for all monitors, not just the one selected.

…ltering

shahzad31 · 2021-10-18T12:40:29Z

Can we hide the step dropdown if ALL_VALUES is selected.

ALL_VALUES isn't even possible to select anymore in monitor name.

I was unable to break down by step name, even when selecting a specific browser monitor. Edit: this happened, even after I fixed my mappings, but I am unable to recreate now. Also, we may need a popover to explain why breakdown by step name is disabled when unavailable.

I have added the tool tooltip in case where it's not available.

We should consider moving fields onto new lines. It's getting crowded, and the flexible layout means that the inputs change size as the user is interacting with them.

Have tried to handle this

When breaking down by step name, we see the step names for all monitors, not just the one selected. Yes this is a broad issue with filering and breakdown, i am planing to handle this by moving layer level filters to global query, i am having few discussions with lens team to handle this.

cc @dominiqueclarke

dominiqueclarke

Should the step name dropdown be available for up pings, down pings, and monitor duration duration metric? When selecting it in those metrics, there is no data data displayed.

When navigating to exploratory view from Uptime, ALL_VALUES is auto selected. Since we removed ALL_VALUES from monitor name, how should we handle navigating from Uptime using the Analyze data button?

...servability/public/components/shared/exploratory_view/series_editor/breakdown/breakdowns.tsx

…ltering

…ory_view/series_editor/breakdown/breakdowns.tsx Co-authored-by: Dominique Clarke <[email protected]>

shahzad31 · 2021-10-18T14:40:04Z

Hidden step name filter for non step level metrics like monitor duration/up pings/down pings

…to step-level-filtering

dominiqueclarke

LGTM

dominiqueclarke · 2021-10-18T17:36:20Z

.../public/components/shared/exploratory_view/configurations/synthetics/kpi_over_time_config.ts

+
+const STEP_METRIC_FILTER: ColumnFilter = {
+  language: 'kuery',
+  query: `synthetics.type: step/metrics`,


No need for backticks here or below, but really not that important.

dominiqueclarke · 2021-10-18T17:38:25Z

...servability/public/components/shared/exploratory_view/series_editor/breakdown/breakdowns.tsx

@@ -51,6 +53,18 @@ export function Breakdowns({ seriesConfig, seriesId, series }: Props) {
    }
  };

+  useEffect(() => {


Not including a dependencies array is a great way to make sure this only fires on the first render. I'll need to remember to use this because I'm often so keyed into wanting to map the effect back to changes in the dependencies. 💯

shahzad31 · 2021-10-18T18:44:15Z

@elasticmachine merge upstream

kibanamachine · 2021-10-18T21:09:01Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`observability`	379.1KB	381.6KB	+2.5KB
`uptime`	571.0KB	571.0KB	+14.0B
total			+2.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`observability`	38.1KB	38.4KB	+344.0B

History

💔 Build #162223 failed 2c665f8
💔 Build #162123 failed a226928
💔 Build #162115 failed 82a1e60
💔 Build #162011 failed c1b2abc
💚 Build #161531 succeeded 92ce1e6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

) Co-authored-by: Dominique Clarke <[email protected]> Co-authored-by: Kibana Machine <[email protected]>

kibanamachine · 2021-10-18T21:12:13Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…115456) Co-authored-by: Dominique Clarke <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Shahzad <[email protected]> Co-authored-by: Dominique Clarke <[email protected]>

Added step level filtering/breakdowns

c9c26ce

shahzad31 self-assigned this Oct 15, 2021

shahzad31 added v7.16.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Oct 15, 2021

shahzad31 marked this pull request as ready for review October 15, 2021 12:53

shahzad31 requested a review from a team as a code owner October 15, 2021 12:53

drewpost requested changes Oct 15, 2021

View reviewed changes

...bservability/public/components/shared/exploratory_view/configurations/constants/constants.ts Show resolved Hide resolved

shahzad31 added 3 commits October 15, 2021 15:39

fix type

4374a21

make step and monitor name single select

4154197

fix test

92ce1e6

drewpost approved these changes Oct 15, 2021

View reviewed changes

dominiqueclarke reviewed Oct 16, 2021

View reviewed changes

shahzad31 added 2 commits October 18, 2021 13:19

Merge branch 'master' of github.com:elastic/kibana into step-level-fi…

6c2e34c

…ltering

pr feedback

c1b2abc

dominiqueclarke self-requested a review October 18, 2021 12:50

dominiqueclarke reviewed Oct 18, 2021

View reviewed changes

...servability/public/components/shared/exploratory_view/series_editor/breakdown/breakdowns.tsx Outdated Show resolved Hide resolved

shahzad31 and others added 6 commits October 18, 2021 16:16

hide step filter for non step metrics

094df34

Merge branch 'master' of github.com:elastic/kibana into step-level-fi…

b18ba48

…ltering

pr feedback

614b486

remove step def when it's not applicable

149d31d

^^also for step name breakdown

affd623

Update x-pack/plugins/observability/public/components/shared/explorat…

82a1e60

…ory_view/series_editor/breakdown/breakdowns.tsx Co-authored-by: Dominique Clarke <[email protected]>

use side effct

1b114e6

dominiqueclarke self-requested a review October 18, 2021 14:45

shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 18, 2021

shahzad31 added 2 commits October 18, 2021 16:48

Merge branch 'step-level-filtering' of github.com:shahzad31/kibana in…

a226928

…to step-level-filtering

update all_value usage

2c665f8

shahzad31 requested a review from drewpost October 18, 2021 17:21

dominiqueclarke approved these changes Oct 18, 2021

View reviewed changes

Merge branch 'master' into step-level-filtering

e02695c

shahzad31 mentioned this pull request Oct 18, 2021

[Uptime] Added trends chart and deep link to exp view on waterfall step metric markers #114068

Merged

shahzad31 enabled auto-merge (squash) October 18, 2021 20:22

shahzad31 merged commit 7e1acab into elastic:master Oct 18, 2021

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 18, 2021

[Exploratory View] Added step level filtering/breakdowns (elastic#115182

672f7d0

) Co-authored-by: Dominique Clarke <[email protected]> Co-authored-by: Kibana Machine <[email protected]>

kibanamachine mentioned this pull request Oct 18, 2021

[7.x] [Exploratory View] Added step level filtering/breakdowns (#115182) #115456

Merged

shahzad31 deleted the step-level-filtering branch November 14, 2021 00:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Exploratory View] Added step level filtering/breakdowns #115182

[Exploratory View] Added step level filtering/breakdowns #115182

shahzad31 commented Oct 15, 2021 •

edited

Loading

elasticmachine commented Oct 15, 2021

drewpost left a comment

drewpost left a comment

dominiqueclarke left a comment •

edited

Loading

shahzad31 commented Oct 18, 2021

dominiqueclarke left a comment

shahzad31 commented Oct 18, 2021

dominiqueclarke left a comment

dominiqueclarke Oct 18, 2021

dominiqueclarke Oct 18, 2021

shahzad31 commented Oct 18, 2021

kibanamachine commented Oct 18, 2021

kibanamachine commented Oct 18, 2021

[Exploratory View] Added step level filtering/breakdowns #115182

[Exploratory View] Added step level filtering/breakdowns #115182

Conversation

shahzad31 commented Oct 15, 2021 • edited Loading

Summary

elasticmachine commented Oct 15, 2021

drewpost left a comment

Choose a reason for hiding this comment

drewpost left a comment

Choose a reason for hiding this comment

dominiqueclarke left a comment • edited Loading

Choose a reason for hiding this comment

shahzad31 commented Oct 18, 2021

dominiqueclarke left a comment

Choose a reason for hiding this comment

shahzad31 commented Oct 18, 2021

dominiqueclarke left a comment

Choose a reason for hiding this comment

dominiqueclarke Oct 18, 2021

Choose a reason for hiding this comment

dominiqueclarke Oct 18, 2021

Choose a reason for hiding this comment

shahzad31 commented Oct 18, 2021

kibanamachine commented Oct 18, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

kibanamachine commented Oct 18, 2021

💚 Backport successful

shahzad31 commented Oct 15, 2021 •

edited

Loading

dominiqueclarke left a comment •

edited

Loading