-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Generate host isolation exceptions artifact #115160
[Security Solution] Generate host isolation exceptions artifact #115160
Conversation
return null; | ||
} | ||
}); | ||
savedObjectsClient.get = jest.fn().mockImplementation(async (objectType: string) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: the only change in this code is removing the unused id
parameter. The big change is due to eslint formatting the code to its new size.
return null; | ||
} | ||
}); | ||
savedObjectsClient.get = jest.fn().mockImplementation(async (objectType: string) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: the only change in this code is removing the unused id
parameter. The big change is due to eslint formatting the code to its new size.
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
1 similar comment
@elasticmachine merge upstream |
x-pack/plugins/security_solution/server/endpoint/lib/artifacts/common.ts
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left just a minor comment. Also - you might need to adjust functional tests (maybe). Lets see if they fail.
🚢
...ns/security_solution/server/endpoint/services/artifacts/manifest_manager/manifest_manager.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after agreeing on artifact naming with @ferullo
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
expected head sha didn’t match current head ref. |
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts.saved objects tagging - functional tests dashboard integration editing allows to select tags for an existing dashboardStandard Out
Stack Trace
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
…tic#115160) Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
) (#115512) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Esteban Beltran <[email protected]>
Summary
Continuation of #111253 #113541 #114279 and #113762
Adds the code to generate the artifact for host isolation exceptions.
Note: I also fixed several eslint problems in this file, mostly unused parameters.
Checklist
Delete any items that are not applicable to this PR.
For maintainers