[Connectors][ServiceNow] Rename isLegacy configuration property #115028

cnasikas · 2021-10-14T14:56:12Z

Summary

Resolves: #114898

For maintainers

This was checked for breaking API changes and was labeled appropriately

kibanamachine · 2021-10-19T12:07:46Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 957c97f
Storybooks Preview
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Test Failures

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/cases/public/components/configure_cases.ConnectorsDropdown it formats the connectors correctly

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `ConnectorsDropdown it formats the connectors correctly 1`

- Snapshot  - 1
+ Received  + 1

@@ -123,11 +123,11 @@
        </EuiFlexItem>
      </EuiFlexGroup>,
      "value": "servicenow-sir",
    },
    Object {
-     "data-test-subj": "dropdown-connector-servicenow-uses-old-api",
+     "data-test-subj": "dropdown-connector-servicenow-uses-table-api",
      "inputDisplay": <EuiFlexGroup
        alignItems="center"
        gutterSize="s"
        responsive={false}
      >
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/cases/public/components/configure_cases/connectors_dropdown.test.tsx:46:33)
    at Promise.then.completed (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:276:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:216:10)
    at _callCircusTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:212:40)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at _runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:63:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/security/public/management/users/edit_user.EditUserPage updates user when submitting form and redirects back

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: thrown: "Exceeded timeout of 5000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.test.tsx:141:3
    at _dispatchDescribe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/index.js:67:26)
    at describe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/index.js:30:5)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.test.tsx:37:1)
    at Runtime._execModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:1299:24)
    at Runtime._loadModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:898:12)
    at Runtime.requireModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:746:10)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:106:13)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/security/public/management/users/edit_user.EditUserPage validates change password form

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/115474

Stack Trace

Error: thrown: "Exceeded timeout of 5000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.test.tsx:328:3
    at _dispatchDescribe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/index.js:67:26)
    at describe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/index.js:30:5)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.test.tsx:37:1)
    at Runtime._execModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:1299:24)
    at Runtime._loadModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:898:12)
    at Runtime.requireModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:746:10)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:106:13)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

and 4 more failures, only showing the first 3.

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cases`	317.5KB	304.0KB	-13.5KB
`triggersActionsUi`	789.4KB	789.4KB	+12.0B
total			-13.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`cases`	80.5KB	80.5KB	+30.0B
`triggersActionsUi`	50.8KB	50.8KB	+4.0B
total			+34.0B

Unknown metric groups

async chunk count

id	before	after	diff
`cases`	15	16	+1

History

💔 Build #162081 failed 7f24f4c
💚 Build #161030 succeeded 7ca7e80
💚 Build #160971 succeeded 6881bb5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

elasticmachine · 2021-10-21T12:23:13Z

Pinging @elastic/security-threat-hunting-cases (Team:Threat Hunting:Cases)

pmuellr

LGTM - thanks for making these changes!

x-pack/plugins/cases/public/components/utils.ts

cnasikas · 2021-10-25T11:09:08Z

@elasticmachine merge upstream

x-pack/plugins/cases/public/components/utils.ts

semd

tested. LGTM!

kibanamachine · 2021-10-25T17:14:00Z

💛 Build succeeded, but was flaky

Test Failures

[job] [logs] Default CI Group #6 / apis Machine Learning job_audit_messages get_job_audit_messages should fetch all audit messages
[job] [logs] Default CI Group #13 / reporting examples Captures PNG that matches the baseline

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cases`	303.6KB	303.7KB	+106.0B
`triggersActionsUi`	813.6KB	813.6KB	+30.0B
total			+136.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`triggersActionsUi`	51.8KB	51.8KB	+4.0B

History

💚 Build #1355 succeeded c900a42
💛 Build #1223 was flaky 07784c1
💔 Build #955 failed ea20851
💔 Build #905 failed 43209bd

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

…tic#115028) Co-authored-by: Kibana Machine <[email protected]>

kibanamachine · 2021-10-25T17:17:11Z

💚 Backport successful

Status	Branch	Result
✅	7.16

This backport PR will be merged automatically after passing CI.

) (#116180) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Christos Nasikas <[email protected]>

Rename isLegacy configuration property

6881bb5

cnasikas added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.16.0 Team:Threat Hunting:Cases labels Oct 14, 2021

cnasikas self-assigned this Oct 14, 2021

More renames

7ca7e80

cnasikas added the bug Fixes for quality problems that affect the customer experience label Oct 18, 2021

cnasikas added 3 commits October 18, 2021 17:02

Merge branch 'master' into sn_rename_legacy_var

7f24f4c

Merge branch 'master' into sn_rename_legacy_var

1c982be

Naming improvements

957c97f

cnasikas added 2 commits October 21, 2021 15:04

Merge branch 'master' into sn_rename_legacy_var

96662c0

Default correlation id

43209bd

cnasikas marked this pull request as ready for review October 21, 2021 12:23

cnasikas requested review from a team as code owners October 21, 2021 12:23

cnasikas requested a review from pmuellr October 21, 2021 12:23

Fixes

ea20851

pmuellr approved these changes Oct 21, 2021

View reviewed changes

cnasikas added 2 commits October 23, 2021 13:52

Merge branch 'master' into sn_rename_legacy_var

468a623

Fix test

07784c1

semd reviewed Oct 25, 2021

View reviewed changes

x-pack/plugins/cases/public/components/utils.ts Outdated Show resolved Hide resolved

Merge branch 'master' into sn_rename_legacy_var

c900a42

jonathan-buttner reviewed Oct 25, 2021

View reviewed changes

x-pack/plugins/cases/public/components/utils.ts Outdated Show resolved Hide resolved

x-pack/plugins/cases/public/components/utils.ts Outdated Show resolved Hide resolved

PR feedback

773df89

jonathan-buttner approved these changes Oct 25, 2021

View reviewed changes

semd approved these changes Oct 25, 2021

View reviewed changes

cnasikas enabled auto-merge (squash) October 25, 2021 14:20

cnasikas added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 25, 2021

cnasikas merged commit 62e2038 into elastic:master Oct 25, 2021

cnasikas deleted the sn_rename_legacy_var branch October 25, 2021 17:13

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 25, 2021

[Connectors][ServiceNow] Rename isLegacy configuration property (elas…

2ab213f

…tic#115028) Co-authored-by: Kibana Machine <[email protected]>

kibanamachine mentioned this pull request Oct 25, 2021

[7.16] [Connectors][ServiceNow] Rename isLegacy configuration property (#115028) #116180

Merged

kibanamachine added a commit that referenced this pull request Oct 25, 2021

[Connectors][ServiceNow] Rename isLegacy configuration property (#115028

222a98a

) (#116180) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Christos Nasikas <[email protected]>

cnasikas mentioned this pull request Nov 1, 2021

[Actions][Docs] Rename isLegacy to usesTableApi #116922

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Connectors][ServiceNow] Rename isLegacy configuration property #115028

[Connectors][ServiceNow] Rename isLegacy configuration property #115028

cnasikas commented Oct 14, 2021 •

edited

Loading

kibanamachine commented Oct 19, 2021 •

edited

Loading

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

async chunk count

elasticmachine commented Oct 21, 2021

pmuellr left a comment

cnasikas commented Oct 25, 2021

semd left a comment

kibanamachine commented Oct 25, 2021

kibanamachine commented Oct 25, 2021

[Connectors][ServiceNow] Rename isLegacy configuration property #115028

[Connectors][ServiceNow] Rename isLegacy configuration property #115028

Conversation

cnasikas commented Oct 14, 2021 • edited Loading

Summary

For maintainers

kibanamachine commented Oct 19, 2021 • edited Loading

💔 Build Failed

Failed CI Steps

Test Failures

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

Metrics [docs]

Async chunks

Page load bundle

async chunk count

History

elasticmachine commented Oct 21, 2021

pmuellr left a comment

Choose a reason for hiding this comment

cnasikas commented Oct 25, 2021

semd left a comment

Choose a reason for hiding this comment

kibanamachine commented Oct 25, 2021

💛 Build succeeded, but was flaky

Test Failures

Metrics [docs]

Async chunks

Page load bundle

History

kibanamachine commented Oct 25, 2021

💚 Backport successful

cnasikas commented Oct 14, 2021 •

edited

Loading

kibanamachine commented Oct 19, 2021 •

edited

Loading