Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vega] Replacing the 'interval' property should only happen for the date_histogram aggregation #115001

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Oct 14, 2021

Summary

Fix regression of #109090. This replacement should only happen for the date_histogram aggregation

Screens

Actual:
image

Expected:
image

@alexwizp alexwizp self-assigned this Oct 14, 2021
@alexwizp alexwizp added v7.16.0 v8.0.0 Feature:Vega Vega visualizations release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed v7.16.0 labels Oct 14, 2021
@alexwizp alexwizp force-pushed the vega-histogram-interval branch from 1d8b2f8 to daf9f3b Compare October 14, 2021 15:15
@alexwizp alexwizp added the backport:skip This commit does not require backporting label Oct 14, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeVega 1.9MB 1.9MB +26.0B

History

  • 💔 Build #160910 failed 1d8b2f841b1ed9af45d5a171c27d91ce664a3c39

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@alexwizp alexwizp marked this pull request as ready for review October 15, 2021 07:53
@alexwizp alexwizp requested a review from a team as a code owner October 15, 2021 07:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch Alex, Code LGTM. I tested it locally in chrome and now it works as expected.

@alexwizp alexwizp merged commit 0fa440a into elastic:master Oct 15, 2021
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jan 17, 2022
alexwizp added a commit that referenced this pull request Jan 17, 2022
* [vega] Handle removal of deprecated date histogram interval (#109090)

* [vega] Handle removal of deprecated date histogram interval

Fixes: #106352

* fix CI

* add deprecation_interval_info

* add test

* Update vega_info_message.tsx

* fix types

* Update es_query_parser.ts

* apply comments

* fix error

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Uladzislau Lasitsa <[email protected]>

* Updates the VEGA docs for v8.0 (#112781)

* Update VEGA docs for v8.0

* Update docs/user/dashboard/vega-reference.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

Co-authored-by: Kaarina Tungseth <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>

* [Vega] Replacing the 'interval' property should only happen for the date_histogram aggregation (#115001)

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Uladzislau Lasitsa <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
Co-authored-by: Kaarina Tungseth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Vega Vega visualizations release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants