-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vega] Replacing the 'interval' property should only happen for the date_histogram aggregation #115001
Conversation
…ate_histogram aggregation
1d8b2f8
to
daf9f3b
Compare
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @alexwizp |
Pinging @elastic/kibana-vis-editors (Team:VisEditors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch Alex, Code LGTM. I tested it locally in chrome and now it works as expected.
…ate_histogram aggregation (elastic#115001)
* [vega] Handle removal of deprecated date histogram interval (#109090) * [vega] Handle removal of deprecated date histogram interval Fixes: #106352 * fix CI * add deprecation_interval_info * add test * Update vega_info_message.tsx * fix types * Update es_query_parser.ts * apply comments * fix error Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Uladzislau Lasitsa <[email protected]> * Updates the VEGA docs for v8.0 (#112781) * Update VEGA docs for v8.0 * Update docs/user/dashboard/vega-reference.asciidoc Co-authored-by: Kaarina Tungseth <[email protected]> Co-authored-by: Kaarina Tungseth <[email protected]> Co-authored-by: Kibana Machine <[email protected]> * [Vega] Replacing the 'interval' property should only happen for the date_histogram aggregation (#115001) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Uladzislau Lasitsa <[email protected]> Co-authored-by: Stratoula Kalafateli <[email protected]> Co-authored-by: Kaarina Tungseth <[email protected]>
Summary
Fix regression of #109090. This replacement should only happen for the
date_histogram
aggregationScreens
Actual
:Expected
: