Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting] Updating alert and action display name to reflect new terminology #114916

Merged
merged 1 commit into from
Oct 14, 2021
Merged

[Alerting] Updating alert and action display name to reflect new terminology #114916

merged 1 commit into from
Oct 14, 2021

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Oct 13, 2021 •
edited
Loading

#113253

Summary

Now shows up in saved objects management UI with correct terminology

Screen Shot 2021-10-13 at 4 56 28 PM

Screen Shot 2021-10-13 at 4 56 43 PM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ymao1 ymao1 self-assigned this Oct 13, 2021
@ymao1 ymao1 added Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.16.0 v8.0.0 labels Oct 14, 2021
@ymao1 ymao1 marked this pull request as ready for review October 14, 2021 11:50
@ymao1 ymao1 requested a review from a team as a code owner October 14, 2021 11:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@ymao1 ymao1 linked an issue Oct 14, 2021 that may be closed by this pull request
[Alerting] Add SavedObjectType.management.displayName for alerts and actions saved objects #113253
Closed
chrisronline
chrisronline approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

YulNaumenko
YulNaumenko approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymao1 ymao1 added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 14, 2021
@ymao1 ymao1 merged commit 0b2012a into elastic:master Oct 14, 2021
@kibanamachine kibanamachine mentioned this pull request Oct 14, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 14, 2021
@ymao1 @kibanamachine
Setting displayname for alerting sos (elastic#114916)
fb98685
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 14, 2021
@kibanamachine @ymao1
Setting displayname for alerting sos (#114916) (#115036)
1479369 
Co-authored-by: ymao1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@chrisronline chrisronline chrisronline approved these changes

Assignees

@ymao1 ymao1

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Alerting] Add SavedObjectType.management.displayName for alerts and actions saved objects
5 participants
@ymao1 @kibanamachine @elasticmachine @chrisronline @YulNaumenko