-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alerting] Always call .resolve()
on the rules detail page
#114670
[Alerting] Always call .resolve()
on the rules detail page
#114670
Conversation
.resolve()
on the rules detail page.resolve()
on the rules detail page
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/maps/get_tile·js.apis Maps endpoints getTile should return vector tile containing documentStandard Out
Stack Trace
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
.resolve()
on the rules detail page.resolve()
on the rules detail page
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #114127
This PR changes how the rule detail page loads rules based on the effort to ensure rules and connectors were sharable in 8.0 to exclusively call the
.resolve()
route. Previously (currently), it attempts to call the.get()
and only calls the.resolve()
if the initial.get()
returned a 404.