Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Show security requirements page when ES security is not enabled #114583

Merged
merged 4 commits into from
Oct 13, 2021
Merged

[Fleet] Show security requirements page when ES security is not enabled #114583

merged 4 commits into from
Oct 13, 2021

Conversation

jen-huang
Copy link
Contributor

Summary

Resolves #83001. When security is not enabled in ES, show requirements UI instead of the erroneous "Superuser required" UI:

image

To test, start ES without security:

yarn es snapshot --license trial -E xpack.security.enabled=false

@jen-huang jen-huang added release_note:fix v8.0.0 Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 12, 2021
@jen-huang jen-huang self-assigned this Oct 12, 2021
@jen-huang jen-huang requested a review from a team as a code owner October 12, 2021 00:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@jen-huang jen-huang enabled auto-merge (squash) October 12, 2021 00:47
criamico
criamico approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 626.1KB 626.0KB -147.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jen-huang

@jen-huang jen-huang merged commit 935ba16 into elastic:master Oct 13, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 13, 2021
@jen-huang @kibanamachine
[Fleet] Show security requirements page when ES security is not enabl…
cfdb2f9 
…ed (elastic#114583)

* Show security requirements page when ES security is not enabled

* Add comments
@kibanamachine kibanamachine mentioned this pull request Oct 13, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 13, 2021
@kibanamachine @jen-huang
[Fleet] Show security requirements page when ES security is not enabl…
b0f53c3 
…ed (#114583) (#114754)

* Show security requirements page when ES security is not enabled

* Add comments

Co-authored-by: Jen Huang <[email protected]>
@jen-huang jen-huang deleted the fix/security-checks branch October 13, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@criamico criamico criamico approved these changes

Assignees

@jen-huang jen-huang

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] Display security checks when security is disabled
4 participants
@jen-huang @elasticmachine @kibanamachine @criamico