-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data views] Make data view saved objects share capable #114408
Conversation
Looking at why the tests are failing: X-Pack Group 2
The error is in the "before each" hook: The index pattern gets converted when kbn-archiver loads the test fixture, and the index pattern's ID changes accordingly, but the Reporting plugin doesn't use You can either change the test fixtures to this an "8.0 index pattern" that doesn't get converted at all, or wait for Reporting to start using X-Pack Group 5 / Group 8
The problem here is that, in the interest of performance, the Spaces API tests are configured to skip the index migration. Normally this would be fine, but since the index patterns are changing to become share-capable, the raw ES documents are no longer valid. E.g., Kibana searches for index pattern "foo" but it does not exist. There are two ways to solve this:
I explored option (1) but it has a lot of downstream effects that would require us to also change lots of test assertions. That, coupled with the huge performance hit (10-20 minutes for the test suite), I think we should do option (2). I'll go ahead and push a commit to your branch to make this change. I expect some of the Saved Object API integration tests will fail too, but we won't see that until we get the Spaces API integration tests to pass. |
I added a8af7f7 to fix the Spaces API integration tests. Let's see the outcome of the next CI run. |
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / general / X-Pack Reporting API Integration Tests.x-pack/test/reporting_api_integration/reporting_and_security/spaces·ts.Reporting APIs Exports and Spaces CSV saved search export should use formats from non-default spacesStandard Out
Stack Trace
Kibana Pipeline / general / X-Pack Reporting API Integration Tests.x-pack/test/reporting_api_integration/reporting_and_security/spaces·ts.Reporting APIs Exports and Spaces CSV saved search export should use formats from non-default spacesStandard Out
Stack Trace
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
@elasticmachine merge upstream |
Looking at the build, it was flaky because an OOM due to a chromedriver problem:
seems like a transient error that is completely unrelated to this change. so I'd say this PR is good to go 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spaces API test changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
@elasticmachine merge upstream |
Matt is out atm, so I'll merge this PR for him 👍 |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Summary
Make data view saved objects share capable.
Closes: #113370