Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Move truncate-by-height into Discover #114320

Merged
merged 38 commits into from
Nov 4, 2021
Merged

[Discover] Move truncate-by-height into Discover #114320

merged 38 commits into from
Nov 4, 2021

Conversation

dimaanj
Copy link
Contributor

@dimaanj dimaanj commented Oct 7, 2021 •
edited
Loading

Summary

Closes #113414

This PR duplicates source formatter for discover plugin locally to get rid of truncate-by-height usage in field-formats plugin. Any UI changes does not expected.

Checklist

@dimaanj dimaanj added Feature:Discover Discover Application v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.16.0 Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Oct 7, 2021
@dimaanj dimaanj self-assigned this Oct 7, 2021
@dimaanj
Copy link
Contributor Author

dimaanj commented Oct 8, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dmitriynj

@dimaanj
Copy link
Contributor Author

dimaanj commented Oct 11, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dmitriynj

@dimaanj dimaanj marked this pull request as ready for review October 11, 2021 19:17
@dimaanj dimaanj requested review from a team as code owners October 11, 2021 19:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

kertal
kertal reviewed Oct 12, 2021
View reviewed changes
Copy link
Member

@kertal kertal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick first feedback: since you moving truncate:maxHeight to discover-truncate-maxheight, the old setting should be migrated, else users would lose their settings when they upgrade. here's an example how that would work: https://github.com/elastic/kibana/blob/8d3645e72fae68c95ea00d616f18cd54d8b356b8/src/core/server/ui_settings/saved_objects/migrations.ts

@dimaanj
Copy link
Contributor Author

dimaanj commented Oct 31, 2021

@elasticmachine merge upstream

@kertal
Copy link
Member

kertal commented Nov 2, 2021

@elasticmachine merge upstream

@dimaanj dimaanj requested a review from timroes November 2, 2021 16:00
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discover 325 341 +16
kibanaLegacy 24 23 -1
total +15

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
discover 58 59 +1
fieldFormats 246 240 -6
kibanaLegacy 9 8 -1
total -6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 303.5KB 303.5KB -50.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 22.8KB 51.8KB +28.9KB
fieldFormats 47.6KB 47.6KB -63.0B
kbnUiSharedDeps-npmDll 5.0MB 5.0MB +1.3KB
kibanaLegacy 4.1KB 3.6KB -441.0B
total +29.7KB
Unknown metric groups

API count

id before after diff
discover 84 85 +1
fieldFormats 284 278 -6
kibanaLegacy 12 11 -1
total -6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dmitriynj

@timroes timroes removed the v7.16.0 label Nov 3, 2021
@dimaanj dimaanj added auto-backport Deprecated - use backport:version if exact versions are needed and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Nov 4, 2021
@dimaanj dimaanj merged commit c7866c3 into elastic:main Nov 4, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 8, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 114320 or prevent reminders by adding the backport:skip label.

@kertal kertal added v8.1.0 and removed v8.0.0 backport missing Added to PRs automatically when the are determined to be missing a backport. labels Nov 8, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 9, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 114320 or prevent reminders by adding the backport:skip label.

@mistic mistic added v8.1.0 and removed v8.1.0 backport missing Added to PRs automatically when the are determined to be missing a backport. labels Nov 10, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 11, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 114320 or prevent reminders by adding the backport:skip label.

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 114320 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 114320 or prevent reminders by adding the backport:skip label.

@kertal kertal added the backport:skip This commit does not require backporting label Nov 15, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl left review comments

@Dosant Dosant Dosant approved these changes

@majagrubic majagrubic majagrubic approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@flash1293 flash1293 flash1293 approved these changes

@timroes timroes timroes approved these changes

@ryankeairns ryankeairns ryankeairns approved these changes

@kertal kertal Awaiting requested review from kertal

Assignees

@dimaanj dimaanj

Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Discover] Move truncate-by-height into Discover