Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting] Initial implementation of alerting task cancel() #114289

Merged
merged 40 commits into from
Nov 16, 2021
Merged
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
793b2ac
Added cancel() to alerting task runner and writing event log document
ymao1 Oct 6, 2021
5bccd7c
Updating rule saved object with timeout execution status
ymao1 Oct 6, 2021
b7d4590
Skip scheduling actions and logging event log for alerts if rule exec…
ymao1 Oct 6, 2021
56e960b
Adding config for disabling skipping actions
ymao1 Oct 6, 2021
226be69
Merge branch 'master' of https://github.com/elastic/kibana into alert…
ymao1 Oct 7, 2021
c2a8602
Fixing types
ymao1 Oct 7, 2021
e376c56
Adding flag for rule types to opt out of skipping acitons
ymao1 Oct 8, 2021
1ed70c5
Merge branch 'master' of https://github.com/elastic/kibana into alert…
ymao1 Oct 8, 2021
658ec46
Merge branch 'master' into alerting/cancel-alerting-tasks
kibanamachine Oct 11, 2021
36a9558
Merge branch 'master' of https://github.com/elastic/kibana into alert…
ymao1 Oct 12, 2021
44db452
Using task runner uuid to differentiate between task instances
ymao1 Oct 12, 2021
11a9cde
Merge branch 'master' of https://github.com/elastic/kibana into alert…
ymao1 Oct 12, 2021
7c6db75
Adding functional test
ymao1 Oct 12, 2021
cff64f1
Merge branch 'master' of https://github.com/elastic/kibana into alert…
ymao1 Oct 12, 2021
fa84e8d
Merge branch 'master' of https://github.com/elastic/kibana into alert…
ymao1 Oct 13, 2021
0ec005a
Default to timestamp when startedAt is not available
ymao1 Oct 13, 2021
8ea6ff0
Merge branch 'master' of https://github.com/elastic/kibana into alert…
ymao1 Oct 13, 2021
4401dbd
Reverting previous change and updating task pool filter instead
ymao1 Oct 13, 2021
096762a
Merge branch 'master' of https://github.com/elastic/kibana into alert…
ymao1 Oct 13, 2021
5b08470
Fixing functional test
ymao1 Oct 13, 2021
7119630
Merge branch 'master' of https://github.com/elastic/kibana into alert…
ymao1 Oct 13, 2021
109ce9b
Merge branch 'master' into alerting/cancel-alerting-tasks
kibanamachine Oct 14, 2021
f327b36
Merge branch 'main' of https://github.com/elastic/kibana into alertin…
ymao1 Nov 1, 2021
9b7570e
Adding debug logging
ymao1 Nov 2, 2021
8b2ebd9
Merge branch 'main' of https://github.com/elastic/kibana into alertin…
ymao1 Nov 2, 2021
44eec3b
Fixing unit tests
ymao1 Nov 2, 2021
5e45e9d
Merge branch 'main' of https://github.com/elastic/kibana into alertin…
ymao1 Nov 2, 2021
3e9b3a9
Fixing unit tests
ymao1 Nov 2, 2021
e5906d4
Merge branch 'main' into alerting/cancel-alerting-tasks
kibanamachine Nov 5, 2021
4672e4a
Merge branch 'main' into alerting/cancel-alerting-tasks
kibanamachine Nov 8, 2021
3ebfbfe
Merge branch 'main' into alerting/cancel-alerting-tasks
kibanamachine Nov 10, 2021
939e665
Merging in main
ymao1 Nov 15, 2021
a7a39a2
Adding rule name to event log doc and rule type timeout to log messages
ymao1 Nov 15, 2021
1787d61
Simplifying register logic and adding check to see if already cancelled
ymao1 Nov 15, 2021
6851db2
Updating task uuid based on PR comments
ymao1 Nov 15, 2021
d769723
Removing observable
ymao1 Nov 15, 2021
0102c2e
Fixing functional test
ymao1 Nov 15, 2021
cc4781b
Merge branch 'main' of https://github.com/elastic/kibana into alertin…
ymao1 Nov 15, 2021
285911b
Adding to docs
ymao1 Nov 16, 2021
030a1fb
Merge branch 'main' of https://github.com/elastic/kibana into alertin…
ymao1 Nov 16, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adding to docs
ymao1 committed Nov 16, 2021
commit 285911b54a169bfabfc1b398b79f11696d1565a7
3 changes: 3 additions & 0 deletions docs/settings/alert-action-settings.asciidoc
Original file line number Diff line number Diff line change
@@ -191,3 +191,6 @@ Specifies the default timeout for the all rule types tasks. The time is formatte
`<count>[ms,s,m,h,d,w,M,Y]`
+
For example, `20m`, `24h`, `7d`, `1w`. Default: `60s`.

`xpack.alerting.cancelAlertsOnRuleTimeout`::
Specifies whether to skip writing alerts and scheduling actions if rule execution is cancelled due to timeout. Default: `true`. This setting can be overridden by individual rule types.