Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Make uptime settings saved object exportable #114235

Merged
merged 2 commits into from
Oct 12, 2021
Merged

[Uptime] Make uptime settings saved object exportable #114235

merged 2 commits into from
Oct 12, 2021

Conversation

shahzad31
Copy link
Contributor

Summary

Fix #82540

Make uptime settings saved object import/exportable

Testing

  1. Change uptime settings
  2. Go to saved objects in stack management
  3. You should see the uptime saved object
  4. Make sure you can export it and download/inspec it

@shahzad31 shahzad31 marked this pull request as ready for review October 7, 2021 08:17
@shahzad31 shahzad31 requested a review from a team as a code owner October 7, 2021 08:17
@shahzad31 shahzad31 added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Oct 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 11, 2021
@shahzad31
Copy link
Contributor Author

@justinkambic this is also ready for review, please.

justinkambic
justinkambic approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzad31 shahzad31 merged commit 7d6aba5 into elastic:master Oct 12, 2021
@shahzad31 shahzad31 deleted the make-uptime-settings-exportable branch October 12, 2021 10:28
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 12, 2021
@shahzad31 @kibanamachine
[Uptime] Make uptime settings saved object exportable (elastic#114235)
8862bf4 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Oct 12, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 12, 2021
@kibanamachine @shahzad31
[Uptime] Make uptime settings saved object exportable (#114235) (#114614
937ea35 
)

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Shahzad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:enhancement Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import and export uptime-dynamic-settings using saved-object management
4 participants
@shahzad31 @elasticmachine @kibanamachine @justinkambic