Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use product names constants #114096

Merged
merged 3 commits into from
Oct 7, 2021
Merged

use product names constants #114096

merged 3 commits into from
Oct 7, 2021

Conversation

klacabane
Copy link
Contributor

Summary

Fixes #114076

Also took the opportunity to replace existing values with the common/constants already defined, as it is done in angular views

Testing

  • verified the elasticsearch page was no longer crashing when entering setupMode
  • verified that corresponding object entry was extracted in setupmode renderer

@klacabane klacabane added v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 Epic: Stack Monitoring de-angularization labels Oct 6, 2021
@klacabane klacabane requested a review from a team as a code owner October 6, 2021 12:36
@klacabane klacabane requested review from a team October 6, 2021 12:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@neptunian
Copy link
Contributor

It looks like the other views in Elasticsearch are also also missing it, though they are not breaking for whatever reason. Could you add them to those as well? ccr_page.tsx, ccr_shard_page.tsx, index_advanced_page.tsx, index_page.tsx, indices_page.tsx, node_page.tsx

@klacabane
Copy link
Contributor Author

Good catch! Added the missing ones

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 1.1MB 1.1MB +206.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

matschaffer
matschaffer approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@matschaffer matschaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I noticed this const in the APM code and thought about doing exactly this. Happy you beat me to it 🧡

@klacabane klacabane merged commit 213c342 into elastic:master Oct 7, 2021
@klacabane klacabane deleted the fix-setup-mode branch October 7, 2021 13:25
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 114096

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 11, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 114096 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 114096 or prevent reminders by adding the backport:skip label.

klacabane added a commit to klacabane/kibana that referenced this pull request Oct 13, 2021
@klacabane
[Stack Monitoring] use product names constants (elastic#114096)
68757fc 
* use product names constants

* add missing productName property
# Conflicts:
#	x-pack/plugins/monitoring/public/application/pages/elasticsearch/ccr_page.tsx
#	x-pack/plugins/monitoring/public/application/pages/elasticsearch/ccr_shard_page.tsx
#	x-pack/plugins/monitoring/public/application/pages/elasticsearch/index_page.tsx
#	x-pack/plugins/monitoring/public/application/pages/elasticsearch/indices_page.tsx
#	x-pack/plugins/monitoring/public/application/pages/elasticsearch/ml_jobs_page.tsx
#	x-pack/plugins/monitoring/public/application/pages/elasticsearch/node_page.tsx
#	x-pack/plugins/monitoring/public/application/pages/elasticsearch/nodes_page.tsx
#	x-pack/plugins/monitoring/public/application/pages/kibana/instances.tsx
#	x-pack/plugins/monitoring/public/application/pages/logstash/nodes.tsx
@klacabane klacabane mentioned this pull request Oct 13, 2021
Merged
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

klacabane added a commit that referenced this pull request Oct 14, 2021
@klacabane
[Stack Monitoring] use product names constants (#114096) (#114796)
8a34af3 
* use product names constants

* add missing productName property
# Conflicts:
#	x-pack/plugins/monitoring/public/application/pages/elasticsearch/ccr_page.tsx
#	x-pack/plugins/monitoring/public/application/pages/elasticsearch/ccr_shard_page.tsx
#	x-pack/plugins/monitoring/public/application/pages/elasticsearch/index_page.tsx
#	x-pack/plugins/monitoring/public/application/pages/elasticsearch/indices_page.tsx
#	x-pack/plugins/monitoring/public/application/pages/elasticsearch/ml_jobs_page.tsx
#	x-pack/plugins/monitoring/public/application/pages/elasticsearch/node_page.tsx
#	x-pack/plugins/monitoring/public/application/pages/elasticsearch/nodes_page.tsx
#	x-pack/plugins/monitoring/public/application/pages/kibana/instances.tsx
#	x-pack/plugins/monitoring/public/application/pages/logstash/nodes.tsx
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matschaffer matschaffer matschaffer approved these changes

@neptunian neptunian neptunian approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Epic: Stack Monitoring de-angularization release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Stack Monitoring] Setup mode is not working for Elasticsearch nodes page
5 participants
@klacabane @elasticmachine @neptunian @kibanamachine @matschaffer