Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability] Move InspectContextProvider and utils to observability #113842

Merged
merged 3 commits into from
Oct 7, 2021

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Oct 4, 2021

Move InspectContextProvider and hook from APM to observability plugin for shared use. We are going to use it in uptime in exact form,

also moved related utility from apm ui server code to observability server.

Testing

As long as CI passes, it should be fine, it's moving files, no code change.

@shahzad31 shahzad31 changed the title move shared stuff [Observability] Move InspectContextProvider and utils to observability Oct 5, 2021
@shahzad31 shahzad31 marked this pull request as ready for review October 5, 2021 07:20
@shahzad31 shahzad31 requested review from a team as code owners October 5, 2021 07:20
@shahzad31 shahzad31 self-assigned this Oct 5, 2021
@shahzad31 shahzad31 added v7.16.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Oct 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@paulb-elastic
Copy link
Contributor

@shahzad31 is this what will give us the option of an Uptime vesion of #113120?

@shahzad31
Copy link
Contributor Author

shahzad31 commented Oct 5, 2021

@shahzad31 is this what will give us the option of an Uptime vesion of #113120?

Yes, this is a progress towards that. Though needs much more work in few other places like #113748

This enhancement in data search plugin.

@paulb-elastic

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Oct 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@@ -25,7 +25,8 @@
"features",
"ruleRegistry",
"timelines",
"triggersActionsUi"
"triggersActionsUi",
"inspector"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetize these please.

@shahzad31 shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 7, 2021
@shahzad31 shahzad31 enabled auto-merge (squash) October 7, 2021 07:56
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1177 1175 -2
observability 361 363 +2
total -0

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 245 257 +12

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
observability 0 1 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.7MB 2.7MB -3.1KB
observability 355.4KB 357.8KB +2.5KB
total -609.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
observability 10 12 +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 29.4KB 29.3KB -139.0B
observability 34.2KB 34.5KB +297.0B
total +158.0B
Unknown metric groups

API count

id before after diff
observability 245 258 +13

async chunk count

id before after diff
observability 9 10 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

@shahzad31 shahzad31 merged commit c2049ed into elastic:master Oct 7, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 113842

@shahzad31 shahzad31 deleted the share-inspect-context branch October 7, 2021 10:11
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 11, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

shahzad31 added a commit that referenced this pull request Oct 11, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants