-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Observability] Move InspectContextProvider and utils to observability #113842
Conversation
Pinging @elastic/uptime (Team:uptime) |
@shahzad31 is this what will give us the option of an Uptime vesion of #113120? |
Yes, this is a progress towards that. Though needs much more work in few other places like #113748 This enhancement in data search plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pinging @elastic/apm-ui (Team:apm) |
@@ -25,7 +25,8 @@ | |||
"features", | |||
"ruleRegistry", | |||
"timelines", | |||
"triggersActionsUi" | |||
"triggersActionsUi", | |||
"inspector" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alphabetize these please.
💚 Build SucceededMetrics [docs]Module Count
Public APIs missing comments
Any counts in public APIs
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
History
To update your PR or re-run it, just comment with: cc @shahzad31 |
💔 Backport failed
To backport manually run: |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
#113842) (#114456) Co-authored-by: Kibana Machine <[email protected]>
Move InspectContextProvider and hook from APM to observability plugin for shared use. We are going to use it in uptime in exact form,
also moved related utility from apm ui server code to observability server.
Testing
As long as CI passes, it should be fine, it's moving files, no code change.