Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Exploratory view] Label field filters/breakdowns #113766

Merged
merged 7 commits into from
Oct 7, 2021
Merged

[Exploratory view] Label field filters/breakdowns #113766

merged 7 commits into from
Oct 7, 2021

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Oct 4, 2021 •
edited
Loading

Summary

Fix elastic/uptime#334

Need feedback on desing/components

Add ability do filtering by label values, and breakdown on label fields

Breakdown

image

Filtering:

image

@shahzad31 shahzad31 force-pushed the label-field-filters branch from 5d4baa3 to 82f78a3 Compare October 4, 2021 14:48
@shahzad31
Copy link
Contributor Author

@liciavale For now it won't be possible to disable label filters where there is no data.

@shahzad31 shahzad31 marked this pull request as ready for review October 4, 2021 16:53
@shahzad31 shahzad31 requested a review from a team as a code owner October 4, 2021 16:53
@shahzad31 shahzad31 self-assigned this Oct 4, 2021
@shahzad31 shahzad31 added v7.16.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Oct 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

dominiqueclarke
dominiqueclarke requested changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The search feature doesn't seem to match all that well.
Screen Shot 2021-10-05 at 12 17 30 PM

Also, when searching I noticed a lot of duplicates came up. These were available when scrolling down past the other search results.

Screen Shot 2021-10-05 at 12 17 39 PM

Tested with dev oblt data for elastic co front end, using the labels.city label.

@shahzad31
Copy link
Contributor Author

The search feature doesn't seem to match all that well.
Also, when searching I noticed a lot of duplicates came up. These were available when scrolling down past the other search results.

Tested with dev oblt data for elastic co front end, using the labels.city label.

@dominiqueclarke i have fixed both issues.

dominiqueclarke
dominiqueclarke approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one note

Issue with the search on the label filter has been resolved.

Screen Shot 2021-10-06 at 9 52 40 AM

...s/observability/public/components/shared/exploratory_view/configurations/constants/labels.ts Outdated
@@ -169,6 +169,15 @@ export const TAGS_LABEL = i18n.translate('xpack.observability.expView.fieldLabel
export const METRIC_LABEL = i18n.translate('xpack.observability.expView.fieldLabels.metric', {
defaultMessage: 'Metric',
});
export const LABELS_FIELD = i18n.translate('xpack.observability.expView.fieldLabels.labels', {
defaultMessage: 'Labels:',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to have a colon?

...bility/public/components/shared/exploratory_view/series_editor/breakdown/label_breakdown.tsx
onChange={(value) => {
setSeries(seriesId, {
...series,
breakdown: value?.[0]?.label ?? LABEL_FIELDS_BREAKDOWN,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a user hits apply before a label is actually selected, and it falls back to LABEL_FIELDS_BREAKDOWN, the view will break. Not sure if this is the biggest issue, as this is a pretty big edge case. If we add back in auto apply though, I'm thinking this would break.

Screen Shot 2021-10-06 at 10 00 32 AM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 361 365 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 355.4KB 358.8KB +3.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

@shahzad31 shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 7, 2021
@shahzad31 shahzad31 merged commit 380c51a into elastic:master Oct 7, 2021
@shahzad31 shahzad31 deleted the label-field-filters branch October 7, 2021 09:49
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 113766

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 11, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 113766 or prevent reminders by adding the backport:skip label.

@shahzad31 shahzad31 mentioned this pull request Oct 11, 2021
Merged
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

shahzad31 added a commit to shahzad31/kibana that referenced this pull request Oct 13, 2021
@shahzad31
[Exploratory view] Label field filters/breakdowns (elastic#113766)
26166d2
shahzad31 added a commit that referenced this pull request Oct 13, 2021
@shahzad31
[Exploratory view] Label field filters/breakdowns (#113766) (#114455)
6b7a891
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees

@shahzad31 shahzad31

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Exploratory View] Add Label as an option in the filter and breakdown selector
4 participants
@shahzad31 @elasticmachine @kibanamachine @dominiqueclarke