[test/page_objects] validate selected dates for timepicker #113597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlemeshko
added
v7.15.1
v7.16.0
v8.0.0
release_note:skip
|
Running 100x x-pack ciGroup1 to check if PR fixes flakiness https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1973 |
|
Flaky test runner passed 100x, retest PR |
|
@elasticmachine merge upstream |
wayneseymour
reviewed
Oct 1, 2021
| @@ -116,23 +116,38 @@ export class TimePickerPageObject extends FtrService { | |||
| public async setAbsoluteRange(fromTime: string, toTime: string) { | |||
| this.log.debug(`Setting absolute range to ${fromTime} to ${toTime}`); | |||
| await this.showStartEndTimes(); | |||
| let panel!: WebElementWrapper; | |||
There was a problem hiding this comment.
Just a nit:
Do we need the non-null assertion operator here?
I don't think WebElementWrapper can be null.
Did your compiler complain?
There was a problem hiding this comment.
Type checker on CI is not happy without it :)
wayneseymour
reviewed
Oct 1, 2021
| 'superDatePickerendDatePopoverButton' | ||
| ); | ||
| this.log.debug(`Validating 'endDate' is set to '${toTime}'`); | ||
| return toTime === actualToTime; |
2 tasks
dmlemeshko
force-pushed
the
ftr/validate-time-picker-date-selection
branch
from
9863ef2 to
02d6a85
Compare
flash1293
approved these changes
Oct 4, 2021
timroes
reviewed
Oct 4, 2021
|
Actually this one #113496 is already unskipped on master. We just need to validate that this fix also stabilizes it in order to not skip it again :) |
|
Agree on checking other skipped tests mentioned in #113520 on flaky-test-runner. |
dmlemeshko
force-pushed
the
ftr/validate-time-picker-date-selection
branch
from
cc438c6 to
a16ccf9
Compare
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/discover/_indexpattern_without_timefield·ts.discover app indexpattern without timefield should switch between with and without timefield using the browser back buttonStandard OutStack TraceMetrics [docs]
History
To update your PR or re-run it, just comment with: |
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Oct 4, 2021
…13597) * [test/page_objects] validate selected dates for timepicker * unskip flaky test * fix types check failure * update tests * update message * unskip more tests
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Oct 4, 2021
…13597) * [test/page_objects] validate selected dates for timepicker * unskip flaky test * fix types check failure * update tests * update message * unskip more tests
dmlemeshko
added a commit
that referenced
this pull request
Oct 4, 2021
dmlemeshko
added a commit
that referenced
this pull request
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding validation+retry logic for time picker absolute value selection.
Partial solution for #113520
Closes #113067
Closes #104578
Closes #60559
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers